0 Fork 0

mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2026-11-10 04:36:40 +00:00

Files

T

kevinveenbirkenbachandClaude Opus 5 dca9db9283 fix(test): resolve the PHP vendor tree against a declared floor

ebb835d541 raised phpunit/phpunit from ^11.0 to ^13.3. PHPUnit 13 requires
PHP >=8.4.1 and ubuntu-latest ships 8.3.6, so composer install could not
resolve and test-unit-php failed on every CI run:

    - phpunit/phpunit[13.3.0, ..., 13.3.2] require php >=8.4.1
      -> your php version (8.3.6) does not satisfy that requirement.

Nothing in this repository installs a particular PHP. ensure_php_toolchain
takes whatever the distro php package is, so the vendor tree was resolved
against an ambient interpreter that no file named. A dependency floor above
that interpreter is then only discovered by the resolver, on the machine that
happens to have the oldest PHP.

Declare the floor and resolve against it. config.platform.php binds composer
everywhere, including Dependabot; require states the same for readers; the
phpunit constraint follows it. Packagist floors: 11 -> >=8.2, 12 -> >=8.3,
13 -> >=8.4.1.

Verified in the dev container: the pinned resolution downgrades phpunit
13.3.2 -> 12.5.34 and the suite passes unchanged, 26 tests, 56 assertions.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-09-09 02:15:56 +02:00

lint

fix(install): drop the shadowed php and ruby dict keys

2026-08-28 12:55:17 +02:00

__init__.py

…

github_release.py

style: delete every comment the comments-valid policy rejects

2026-08-18 03:22:02 +02:00

interpreters.py

feat(image): bake the php and ruby interpreters into the image

2026-08-22 20:56:55 +02:00

node.py

fix(test): install php and ruby instead of skipping their suites

2026-08-22 20:30:40 +02:00

npm.py

…

php.py

fix(test): resolve the PHP vendor tree against a declared floor

2026-09-09 02:15:56 +02:00

pip.py

…

primitives.py

fix(install): retry transient download failures, keep 4xx fatal

2026-08-10 10:12:20 +02:00

README.md

refactor(layout): sort shipped scripts by language and split the unit suite

2026-08-22 01:31:09 +02:00

ruby.py

fix(test): install php and ruby instead of skipping their suites

2026-08-22 20:30:40 +02:00

system_pkg.py

fix(install): drop the shadowed php and ruby dict keys

2026-08-28 12:55:17 +02:00

README.md

utils/install

This directory hosts the Python implementation behind make install-lint. For the general rules that govern READMEs in code directories see documentation.md.

Purpose

The package installs the lint toolchain (actionlint, shfmt, ruff, ansible-lint, mbake, markdownlint-cli2, eslint, shellcheck, ansible-playbook, ansible-galaxy) using the right channel per tool (system package manager, pip, npm, or GitHub release). Modules at this level are channel-agnostic primitives; per-tool policy lives one level down in lint/.

Structure

File	Role
`primitives.py`	Logging, sudo wrapping, PATH mutation, and stdlib-based URL download.
`pip.py`	Venv-aware pip installer with `--break-system-packages` and `--user` fallback.
`npm.py`	Global / local npm install with per-user `--prefix` fallback.
`github_release.py`	Latest-tag resolver and asset downloader for GitHub releases.
`system_pkg.py`	Per-manager dispatch for `pacman` / `apt-get` / `dnf` / `yum` / `brew`.
`lint/`	One module per tool, each exposing `ensure()`. See lint README.

The CLI entry point lives at __main__.py, invoked from lint.sh as python3 -m utils.install.lint. The matching dispatcher wrapper.sh routes make install-lint host vs container based on INFINITO_LINT_RUNNER.

File Naming

Module names MUST stay lowercase snake_case.
Channel-agnostic helpers MUST live directly under utils/install/.
Per-tool policy (one tool per file) MUST live under lint/ (see lint README).
Test files live in tests/unit/python/utils/install/ and mirror the module name with a test_ prefix.

Import Rules

primitives.py MUST NOT import from any other module in this package.
pip.py, npm.py, github_release.py, and system_pkg.py MAY import from primitives.py.
npm.py MAY import from system_pkg.py to bootstrap npm itself; no other cross-imports between these four are allowed.
Per-tool modules under lint/ MUST NOT import each other (see lint README).