mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 4.7
26ef3ff504
Adds ``[tool.ruff.lint]`` with ``select = ["E", "F", "I", "B", "UP"]``
and ``target-version = "py311"``. ``E501`` is ignored because
``ruff format`` already reflows what it can; the remaining long lines
are unsplittable string literals / URLs.
Auto-fixed (2753 issues, behavior-preserving):
- UP006/UP035: ``List[X]`` → ``list[X]``, ``Dict[X]`` → ``dict[X]``,
``from typing import …`` redirected where superseded by builtins.
- UP045: ``Optional[X]`` → ``X | None``.
- UP010/UP009/UP015: dropped Python-2-era pragmas (``from __future__
import absolute_import, division, print_function``,
``# -*- coding: utf-8 -*-``), redundant ``open(..., "r")`` mode.
- UP004: dropped implicit ``class X(object):``.
- UP022/UP008/UP032: stdlib idiom modernization (``capture_output``,
super-call simplification, etc.).
- B905: ``zip(...)`` → ``zip(..., strict=False)`` (preserves prior
behavior; switching to ``strict=True`` is a separate semantic
choice not made here).
- I001: import-block ordering.
Hand-fixed (66 issues):
- B904 × 54: appended ``from <bound>`` (when the enclosing ``except``
binds a name) or ``from None`` (when it doesn't) so chained
exceptions stay distinguishable from errors-during-exception-
handling. Applied via a small AST-aware script that walked back to
the enclosing ``except`` clause and matched the binding.
- B017 × 4: narrowed broad ``assertRaises(Exception)`` to the actual
``AnsibleError`` / ``AnsibleFilterError`` raised by the code under
test.
- B023 × 2: bound captured loop variables via default args
(``def _record(name, *, _path_real=path_real, ...)``) so each
closure gets its own snapshot.
- B007 × 2: unused loop control variables renamed to ``_`` /
rewritten to ``.values()``.
- UP007 × 2: ``Union[X, Y]`` → ``X | Y`` (plus dropping the now-unused
``from typing import Union``).
- B018 × 1: Odoo addon manifests are bare dict expressions at module
level by design — suppressed with an inline ``# noqa: B018`` and
rationale comment.
- UP031 × 1: printf-style format → f-string.
The 65 ``# noqa: …`` markers introduced by the auto-fixer all carry
real ruff codes (``B018``, ``E402``, ``F401``, etc.), so
``test_noqa_only_ruff_codes`` stays green.
Verification
============
- ``ruff check .`` → All checks passed
- ``ruff format --check .`` → 894 files already formatted
- ``tests.lint.repository.{test_project_root_import,
test_no_direct_yaml_calls, test_noqa_only_ruff_codes}`` and
``tests.unit.utils.annotations.test_suppress`` → 20 tests OK
- 1621 unit tests → all pass
- Integration suite: 44 failures (pre-existing baseline, none from
this change), 1 skipped.
Going forward, the new rules block regressions on E (style), F
(pyflakes), I (import order), B (likely-bug patterns), and UP
(modernization to py311) for any new code.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
55 lines
2.2 KiB
Python
55 lines
2.2 KiB
Python
"""In-process caches for runtime data (applications, users, domains).
|
|
|
|
Domain modules:
|
|
|
|
- ``utils.cache.base`` — cross-cutting helpers (constants,
|
|
deep-merge, signatures, render machinery).
|
|
- ``utils.cache.applications`` — variants + ``get_merged_applications``
|
|
(ansible-free at import time, runner-host friendly).
|
|
- ``utils.cache.users`` — ``get_user_defaults``, ``get_merged_users``.
|
|
- ``utils.cache.domains`` — ``get_merged_domains``.
|
|
- ``utils.cache.yaml`` — process-wide ``load_yaml`` /
|
|
``load_yaml_any`` parser cache shared by everything that reads YAML
|
|
off-disk.
|
|
- ``utils.cache.files`` — process-wide project-tree walk +
|
|
file-content cache (``read_text``, ``iter_project_files``,
|
|
``iter_non_ignored_files``).
|
|
- ``utils.cache.gitignore`` — cached ``.gitignore`` pattern loader
|
|
+ path matcher used by lint/integration tests that need a
|
|
"files git would track" view without spawning git.
|
|
|
|
Use the domain module directly. The package-level
|
|
``_reset_cache_for_tests`` clears every domain's caches plus the shared
|
|
fingerprint memo in one call — preferred over hand-rolling N
|
|
``_reset()`` calls per test fixture.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
# Repository root, derived once from this package's location. Single
|
|
# source of truth for every callsite in the project that needs to
|
|
# reach the repo root (CLI tools, plugins, tests). External consumers
|
|
# MUST import this value rather than re-derive it via
|
|
# `Path(__file__).parents[N]` or `os.pardir` chains; the
|
|
# `tests/lint/repository/test_project_root_import.py` lint enforces it.
|
|
PROJECT_ROOT: Path = Path(__file__).resolve().parents[2]
|
|
ROLES_DIR: Path = PROJECT_ROOT / "roles"
|
|
|
|
|
|
def _reset_cache_for_tests() -> None:
|
|
"""Orchestrate per-domain cache resets plus the shared fingerprint
|
|
memo. Test fixtures rely on a single entry point so they can stay
|
|
agnostic of how the cache is partitioned across modules."""
|
|
from . import applications, base, domains, files, gitignore, users
|
|
from . import yaml as _yaml_cache
|
|
|
|
applications._reset()
|
|
users._reset()
|
|
domains._reset()
|
|
base._reset()
|
|
_yaml_cache._reset()
|
|
files._reset()
|
|
gitignore._reset()
|