Files
computer-playbook/tests/unit/plugins/lookup/test_compose_file_args.py
T
kevinveenbirkenbachandClaude Opus 4.7 d3afe0bc81 test(lint): forbid a file from referencing its own path as a string
Hard-coded self-path references rot the moment the file moves: a header
comment ``# utils/foo/bar.py`` at the top of a module, a docstring
mentioning ``utils/foo/bar.py``, or a docs entry linking
``utils/foo/bar.py`` from inside ``utils/foo/bar.py`` itself all silently
desync from reality after the next ``git mv``.

The new lint walks every project file, computes its POSIX-style relative
path from PROJECT_ROOT, and reports any line whose text contains that
path as a substring. Files at the repo root (no ``/`` in their relative
path) and setuptools-generated ``*.egg-info/`` artefacts are exempt.
Per-line opt-out via ``# nocheck: self-path-reference`` on the offending
line, registered in the suppression catalog.

Existing offenders cleaned up:
- 72 redundant ``# <self-path>`` header lines removed across roles,
  cli, plugins, scripts, tests, and utils.
- 4 prometheus templates that told consumers to "update
  <self-template-path>" rewritten to drop the redundant self-reference.
- 8 docstring/comment self-references in cli, plugins, tests, utils,
  and the dashboard oidc.js.j2 header rewritten to describe the layout
  without naming the file's own path.
- 17 legitimate usage examples (shell scripts, test data lists, one
  template self-include doc-block) marked with ``nocheck:
  self-path-reference``.
- ``container.sh`` heredoc usage strings switched to ``${0}`` so the
  marker stays out of the user-visible help output.
- ``healthcheck/http.yml.j2`` doc-block rewritten to prose because
  ``{# ... #}`` Jinja comments cannot host an inner ``{# nocheck #}``
  (the inner ``#}`` closes the outer comment).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 03:53:44 +02:00

181 lines
6.4 KiB
Python

import importlib.util
import unittest
from unittest.mock import patch
from ansible.errors import AnsibleError
from . import PROJECT_ROOT
def _load_module(rel_path: str, name: str):
path = PROJECT_ROOT / rel_path
spec = importlib.util.spec_from_file_location(name, str(path))
mod = importlib.util.module_from_spec(spec)
assert spec and spec.loader
spec.loader.exec_module(mod)
return mod
class _TlsResolveStub:
def __init__(self, enabled: bool, mode: str):
self._enabled = enabled
self._mode = mode
def run(self, terms, variables=None, **kwargs):
return [{"enabled": self._enabled, "mode": self._mode}]
class TestComposeFArgs(unittest.TestCase):
def setUp(self):
self.m = _load_module(
"plugins/lookup/compose_file_args.py",
"compose_file_args_mod",
)
self.lookup = self.m.LookupModule()
# In real Ansible, LookupBase gets _loader/_templar injected.
# For unit tests, set them to placeholders.
self.lookup._loader = object()
self.lookup._templar = object()
# compose_file_args no longer reads variables['compose'].
# It builds compose via get_docker_paths(application_id, DIR_COMPOSITIONS).
self.vars = {
"DIR_COMPOSITIONS": "/x/",
"domains": {
"web-app-a": "example.invalid",
},
}
# Route get_merged_domains through variables['domains'] to keep tests hermetic.
def _domains_from_vars(*, variables=None, **_kwargs):
return (variables or {}).get("domains", {})
self._domains_patcher = patch.object(
self.m,
"get_merged_domains",
side_effect=_domains_from_vars,
)
self._domains_patcher.start()
self.addCleanup(self._domains_patcher.stop)
def _stub_get_docker_paths(self, application_id: str, base_dir: str) -> dict:
# Keep structure identical to utils.docker.paths_utils.get_docker_paths()
# but stable for unit tests.
self.assertEqual(application_id, "web-app-a")
self.assertEqual(base_dir, "/x/")
return {
"files": {
"compose": "/x/compose.yml",
"compose_override": "/x/compose.override.yml",
"compose_ca_override": "/x/compose.ca.override.yml",
}
}
def test_includes_base_and_override_when_role_provides_override_and_tls_off(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader, "get", return_value=_TlsResolveStub(False, "off")
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(out, "-f /x/compose.yml -f /x/compose.override.yml")
def test_includes_ca_override_when_self_signed_and_domain_exists(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
return_value=_TlsResolveStub(True, "self_signed"),
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(
out,
"-f /x/compose.yml -f /x/compose.override.yml -f /x/compose.ca.override.yml",
)
def test_fails_when_ca_override_missing_but_required(self):
def stub_missing_ca(application_id: str, base_dir: str) -> dict:
return {
"files": {
"compose": "/x/compose.yml",
"compose_override": "/x/compose.override.yml",
"compose_ca_override": "",
}
}
with (
patch.object(self.m, "get_docker_paths", side_effect=stub_missing_ca),
patch.object(self.m, "_role_provides_override", return_value=True),
patch.object(
self.m.lookup_loader,
"get",
return_value=_TlsResolveStub(True, "self_signed"),
),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
def test_includes_only_base_when_role_does_not_provide_override(self):
with (
patch.object(
self.m, "get_docker_paths", side_effect=self._stub_get_docker_paths
),
patch.object(self.m, "_role_provides_override", return_value=False),
patch.object(
self.m.lookup_loader, "get", return_value=_TlsResolveStub(False, "off")
),
):
out = self.lookup.run(["web-app-a"], variables=self.vars)[0]
self.assertEqual(out, "-f /x/compose.yml")
def test_requires_one_term(self):
with self.assertRaises(AnsibleError):
self.lookup.run([], variables=self.vars)
with self.assertRaises(AnsibleError):
self.lookup.run(["a", "b"], variables=self.vars)
def test_requires_path_docker_compose_instances(self):
with self.assertRaises(AnsibleError):
self.lookup.run(
["web-app-a"], variables={"domains": {"web-app-a": "example.invalid"}}
)
def test_requires_docker_compose_structure_from_get_docker_paths(self):
# get_docker_paths returns non-dict -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value="nope"),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
# get_docker_paths returns dict but missing files -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value={}),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
# get_docker_paths returns dict with non-dict files -> must fail
with (
patch.object(self.m, "get_docker_paths", return_value={"files": "nope"}),
self.assertRaises(AnsibleError),
):
self.lookup.run(["web-app-a"], variables=self.vars)
if __name__ == "__main__":
unittest.main()