mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 4.7
a5ba14d5b3
Widens the cache-read lint guard from ``tests/lint/`` to every ``.py`` under ``tests/``. Integration tests show the same compounding cost pattern (one role's compose template / nginx conf / scrape fragment read across many shape tests) that motivated the original lint for lint/. Converts 91 violations across 28 test files: - **Cache (utils.cache.files.read_text)** for project-tracked reads and single-read tempdir fixtures, e.g. test_prometheus.py (32x), test_keycloak_import_flow.py (11x), test_dashboard_oidc.py (3x), test_changelog_md.py (8x), test_package_mirror.py (8x), plus test_logging.py / test_summarize.py / test_version_updater.py / test_get_url_retry.py / test_pull_specific_host.py. - **Cache + UnicodeDecodeError handler** for project-walk scanners that previously used ``errors="replace"`` / ``errors="ignore"`` to defend against non-UTF-8 files (compose volumes, password quoting, template image, mailu dependency, URL reachability). Wraps each read in ``try/except (OSError, UnicodeDecodeError): continue``, which has the same observable effect (skip undecodable files). - **Refactor away the binary heuristic** in test_no_raw_docker.py: ``read_bytes() + b"\x00" not in raw`` becomes ``read_text() / except UnicodeDecodeError``. Same files skipped, with cache benefit. - **Variable extraction** in test_changelog_md.py / test_package_mirror.py for cases where ``self.assertEqual(path.read_text(...), expected)`` exceeded ruff's 88-char limit. Ruff was wrapping the marker onto a line outside the AST span of the read_text call. - **Compute-from-setup** for two test methods that previously read ``self.changelog`` twice (before/after) to verify a no-op: ``before`` is now derived from the known input, dropping the first read. Five ``# nocheck: cache-read`` markers remain, each annotated inline with the reason: idempotency tests where the second read must hit disk to catch non-idempotent regressions, and tests with intermediate ``write_text`` whose subsequent read would return stale cache data. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
33 lines
931 B
Python
33 lines
931 B
Python
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from cli.core.run import open_log_file
|
|
from utils.cache.files import read_text
|
|
|
|
|
|
class TestLogging(unittest.TestCase):
|
|
def test_open_log_file_creates_parents_and_writes(self):
|
|
with tempfile.TemporaryDirectory() as td:
|
|
# nested path to ensure parents=True behavior is exercised
|
|
log_dir = Path(td) / "a" / "b" / "c" / "logs"
|
|
|
|
self.assertFalse(log_dir.exists())
|
|
f, path = open_log_file(log_dir)
|
|
try:
|
|
self.assertTrue(log_dir.exists())
|
|
self.assertTrue(path.exists())
|
|
self.assertIn(log_dir, path.parents)
|
|
|
|
f.write("hello\n")
|
|
f.flush()
|
|
|
|
content = read_text(str(path))
|
|
self.assertIn("hello", content)
|
|
finally:
|
|
f.close()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|