mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 4.7
eb4bcd23a8
Three new lint tests close gaps in the INFINITO_* SPOT contract:
* tests/lint/filesystem/env/test_default_env_keys_handled.py
Every default.env key must be wired through a handler.
* tests/lint/filesystem/env/test_used_keys_declared.py
Every INFINITO_* in .sh/.py must live in env/{default,ci}.env or
a handler; per-line `# nocheck:` suppresses runtime-only refs.
* tests/lint/filesystem/python/test_no_infinito_get_defaults.py
Forbid ANY default in `.get("INFINITO_*", ...)` -- including the
empty-string fallback (which silently masks an unset key). The
nocheck check walks every physical line the call spans so an
autoformat-split call still honours the marker.
Cache namespace flattens to a single prefix:
INFINITO_PACKAGE_CACHE_* -> INFINITO_CACHE_PACKAGE_*
INFINITO_REGISTRY_CACHE_* -> INFINITO_CACHE_REGISTRY_*
The five previously driver-injected paths (APT_LIST, NPMRC,
PIP_CONF, REGISTRY_PROXY_CONF, FRONTEND_CA_FILE) move into
env/default.env and passthrough.STATIC_KEYS; the
`cache_env_overrides()` helper and its two call sites are gone
along with the test-fixture override for FRONTEND_CA_DIR.
SPOT-strict rewrites:
- 19 sites: `something.get("INFINITO_X", "")` -> subscript
`something["INFINITO_X"]` (loud KeyError when env loader did
not run; all keys live in env/default.env).
- 2 handler-internal bootstrap reads suppressed with
`# nocheck: handler-bootstrap-read`.
- 30 runtime-only / driver-injected / test-fixture references
annotated with `# nocheck: <reason>` per-line.
- Unit tests that previously removed SPOT-guaranteed keys via
`{k: v ... if k \!= KEY}` or `clear=True` switch to setting
the key to "" explicitly, matching the new contract.
Side fixes:
- INFINITO_DNS_DOMAIN + INFINITO_DNS_HOSTS_FILE move from
shell-side defaults in common.sh to env/default.env and
passthrough.STATIC_KEYS.
- dns_systemd_is_operational() drops the dead
INFINITO_DNS_FORCE_HOSTS_FALLBACK override branch (the
variable was never set anywhere).
- INFINITO_WORKER_FETCH switches from `os.environ.get(KEY, "1")`
to `os.environ[KEY]`.
- scripts/tests/code/wrapper.sh exec args move into a bash
array so `# nocheck:` on INFINITO_TEST_TYPE can live on its
own element line (SC2215 fix).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
48 lines
1.7 KiB
Python
48 lines
1.7 KiB
Python
from __future__ import annotations
|
|
|
|
import os
|
|
import unittest
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from cli.administration.deploy.development.network import detect_outer_network_mtu
|
|
|
|
|
|
class TestDetectOuterNetworkMtu(unittest.TestCase):
|
|
@patch.dict(os.environ, {"INFINITO_OUTER_NETWORK_MTU": "1300"}, clear=False)
|
|
def test_prefers_explicit_outer_network_mtu_env(self) -> None:
|
|
self.assertEqual(detect_outer_network_mtu(), "1300")
|
|
|
|
@patch.dict(os.environ, {"INFINITO_OUTER_NETWORK_MTU": ""}, clear=True)
|
|
@patch("cli.administration.deploy.development.network.Path.exists", autospec=True)
|
|
@patch(
|
|
"cli.administration.deploy.development.network.Path.read_text", autospec=True
|
|
)
|
|
def test_reads_outer_network_mtu_from_host_docker_daemon(
|
|
self,
|
|
read_text_mock: MagicMock,
|
|
exists_mock: MagicMock,
|
|
) -> None:
|
|
exists_mock.side_effect = lambda path: str(path) == "/etc/docker/daemon.json"
|
|
read_text_mock.return_value = '{"mtu": 1400}'
|
|
|
|
self.assertEqual(detect_outer_network_mtu(), "1400")
|
|
|
|
@patch.dict(os.environ, {"INFINITO_OUTER_NETWORK_MTU": ""}, clear=True)
|
|
@patch("cli.administration.deploy.development.network.Path.exists", autospec=True)
|
|
@patch(
|
|
"cli.administration.deploy.development.network.Path.read_text", autospec=True
|
|
)
|
|
def test_ignores_invalid_daemon_config(
|
|
self,
|
|
read_text_mock: MagicMock,
|
|
exists_mock: MagicMock,
|
|
) -> None:
|
|
exists_mock.side_effect = lambda path: str(path) == "/etc/docker/daemon.json"
|
|
read_text_mock.return_value = '{"mtu": 64}'
|
|
|
|
self.assertIsNone(detect_outer_network_mtu())
|
|
|
|
|
|
if __name__ == "__main__": # pragma: no cover
|
|
unittest.main()
|