mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-11 21:26:44 +00:00
kevinveenbirkenbachandClaude Opus 4.7
f6c8c85b1b
Add tests/lint/repository/test_role_file_spot.py: AST-walks every .py file under the production trees and tests/, flags any reference to a role file (standalone literal, f-string segment, pathlib `/` chain, `+` concat chain, os.path.join / Path.joinpath / posixpath.join / ntpath.join call) whose value or joined trailing operands match a ROLE_FILE_* constant in utils.roles.mapping. The flag set is auto-discovered from the module so adding a new constant extends coverage without further edits. ROLE_FILE_README is exempt as too generic. Per-line `# nocheck: role-file-spot` (same-or-above) is the documented opt-out, catalog row added in docs/contributing/actions/testing/suppression.md. Migrate 139 .py files (377 occurrences) to use the constants: - 135 files via direct constant import (`from utils.roles.mapping import ROLE_FILE_*`), with the symbol used in pathlib chains, in os.path.join / Path.joinpath calls, in f-string interpolation, and in glob patterns. - 4 files via `# nocheck: role-file-spot` where the literal lives in argparse help text or in an allowlist tuple meant to declare the literal path. Adjust utils/roles/dependency_resolver.py to use lazy-formatting positional args in the logger.exception call (G003-clean) instead of string concatenation against the constant. Drop a redundant `if cond: return True; return False` guard in the new test for `return cond` (SIM103-clean). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
107 lines
3.4 KiB
Python
107 lines
3.4 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from typing import Any
|
|
|
|
from ansible.errors import AnsibleError
|
|
from ansible.plugins.lookup import LookupBase
|
|
|
|
from plugins.lookup import PROJECT_ROOT
|
|
from utils.cache.applications import get_merged_applications
|
|
from utils.cache.base import (
|
|
_cache_key,
|
|
_resolve_roles_dir,
|
|
_stable_variables_signature,
|
|
)
|
|
from utils.cache.yaml import load_yaml_any
|
|
from utils.roles.applications.in_group_deps import applications_if_group_and_all_deps
|
|
from utils.roles.applications.services.registry import (
|
|
build_service_registry_from_applications,
|
|
)
|
|
from utils.roles.mapping import ROLE_FILE_META_MAIN
|
|
|
|
_CURRENT_PLAY_CACHE: dict[tuple, dict[str, Any]] = {}
|
|
|
|
|
|
def _reset_cache_for_tests() -> None:
|
|
_CURRENT_PLAY_CACHE.clear()
|
|
|
|
|
|
class LookupModule(LookupBase):
|
|
"""
|
|
Return the current play application mapping using the shared resolver from
|
|
utils/roles/applications/in_group_deps.
|
|
"""
|
|
|
|
def run(
|
|
self,
|
|
terms: list[Any],
|
|
variables: dict[str, Any] | None = None,
|
|
**kwargs: Any,
|
|
) -> list[dict[str, Any]]:
|
|
vars_ = variables or getattr(self._templar, "available_variables", {}) or {}
|
|
|
|
roles_dir_arg = kwargs.get("roles_dir")
|
|
project_root = self._get_project_root()
|
|
roles_dir = roles_dir_arg or str(Path(project_root) / "roles")
|
|
|
|
group_names = vars_.get("group_names", []) or []
|
|
resolved_roles_dir = _resolve_roles_dir(roles_dir=roles_dir_arg)
|
|
cache_key = (
|
|
_cache_key(resolved_roles_dir),
|
|
_stable_variables_signature(vars_),
|
|
tuple(group_names),
|
|
)
|
|
cached = _CURRENT_PLAY_CACHE.get(cache_key)
|
|
if cached is not None:
|
|
return [cached]
|
|
|
|
applications = get_merged_applications(
|
|
variables=vars_,
|
|
roles_dir=roles_dir_arg,
|
|
templar=getattr(self, "_templar", None),
|
|
)
|
|
service_registry = build_service_registry_from_applications(applications)
|
|
|
|
try:
|
|
result = applications_if_group_and_all_deps(
|
|
applications,
|
|
group_names,
|
|
project_root=project_root,
|
|
roles_dir=roles_dir,
|
|
service_registry=service_registry,
|
|
meta_deps_resolver=self._meta_deps,
|
|
)
|
|
except (TypeError, ValueError) as exc:
|
|
raise AnsibleError(f"applications_current_play: {exc}") from exc
|
|
|
|
_CURRENT_PLAY_CACHE[cache_key] = result
|
|
return [result]
|
|
|
|
# ------------------------------------------------------------------
|
|
# Helpers
|
|
# ------------------------------------------------------------------
|
|
|
|
def _get_project_root(self) -> str:
|
|
return str(PROJECT_ROOT)
|
|
|
|
def _meta_deps(self, role: str, roles_dir: str) -> list[str]:
|
|
meta_file = str(Path(roles_dir) / role / ROLE_FILE_META_MAIN)
|
|
if not Path(meta_file).is_file():
|
|
return []
|
|
try:
|
|
meta = load_yaml_any(meta_file, default_if_missing={}) or {}
|
|
except Exception:
|
|
return []
|
|
if not isinstance(meta, dict):
|
|
return []
|
|
deps = []
|
|
for dep in meta.get("dependencies", []):
|
|
if isinstance(dep, str):
|
|
deps.append(dep)
|
|
elif isinstance(dep, dict):
|
|
name = dep.get("role") or dep.get("name")
|
|
if name:
|
|
deps.append(name)
|
|
return deps
|