mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 02:54:26 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
87 lines
3.3 KiB
Python
87 lines
3.3 KiB
Python
import unittest
|
|
|
|
from utils.roles.display import display_names, split_axes
|
|
|
|
APP = "web-app-nextcloud"
|
|
|
|
|
|
class TestRoleDisplayName(unittest.TestCase):
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.codec = display_names()
|
|
|
|
def test_encode_runs_the_category_labels_together_before_the_heading(self):
|
|
self.assertEqual(
|
|
f"{''.join(self.codec.category_labels(APP))}·{self.codec.title(APP)}",
|
|
self.codec.encode(APP),
|
|
)
|
|
|
|
def test_a_heading_longer_than_the_id_section_loses_to_it(self):
|
|
long_heading = "svc-runner"
|
|
self.assertGreater(
|
|
len(self.codec.title(long_heading)),
|
|
len(self.codec.id_fragment(long_heading)),
|
|
)
|
|
self.assertTrue(
|
|
self.codec.encode(long_heading).endswith(
|
|
f"·{self.codec.id_fragment(long_heading)}"
|
|
),
|
|
self.codec.encode(long_heading),
|
|
)
|
|
self.assertEqual(
|
|
"系统控制告警·compose", self.codec.encode("sys-ctl-alm-compose")
|
|
)
|
|
|
|
def test_the_id_section_drops_what_the_categories_already_say(self):
|
|
self.assertEqual("nextcloud", self.codec.id_fragment(APP))
|
|
self.assertEqual("update", self.codec.id_fragment("update"))
|
|
|
|
def test_the_variant_is_joined_without_whitespace(self):
|
|
encoded = self.codec.encode(APP, "0,1")
|
|
self.assertNotIn(" ", encoded)
|
|
self.assertEqual(f"{self.codec.encode(APP)}#0,1", encoded)
|
|
|
|
def test_decode_reverses_encode_with_and_without_a_variant(self):
|
|
for variant in ("", "0", "0,1"):
|
|
self.assertEqual(APP, self.codec.decode(self.codec.encode(APP, variant)))
|
|
|
|
def test_decode_passes_a_role_id_through(self):
|
|
self.assertEqual(APP, self.codec.decode(APP))
|
|
self.assertEqual(APP, self.codec.decode(f"{APP}#0,1"))
|
|
|
|
def test_decode_rejects_what_names_no_role(self):
|
|
self.assertIsNone(self.codec.decode("Update Docker image versions"))
|
|
self.assertIsNone(self.codec.decode(""))
|
|
|
|
def test_lists_round_trip_and_keep_sentinels(self):
|
|
ids = f"{APP} svc-db-postgres __ALL__"
|
|
self.assertEqual(ids, self.codec.decode_list(self.codec.encode_list(ids)))
|
|
|
|
def test_an_axis_suffix_survives_the_decode(self):
|
|
encoded = f"{self.codec.encode(APP)}#0,2@swarm+tor"
|
|
self.assertEqual(f"{APP}#0,2@swarm+tor", self.codec.decode_list(encoded))
|
|
|
|
def test_a_role_id_holds_no_axis_seam(self):
|
|
self.assertEqual((APP, ""), split_axes(APP))
|
|
self.assertEqual((APP, "@host"), split_axes(f"{APP}@host"))
|
|
|
|
def test_every_role_encodes_to_one_unique_space_free_token(self):
|
|
seen: dict[str, str] = {}
|
|
collisions = []
|
|
spaced = []
|
|
for path in sorted(self.codec.roles_dir.iterdir()):
|
|
if not (path / "README.md").is_file():
|
|
continue
|
|
name = self.codec.encode(path.name)
|
|
if " " in name:
|
|
spaced.append(f"{path.name}: {name}")
|
|
if name in seen:
|
|
collisions.append(f"{name}: {seen[name]} vs {path.name}")
|
|
seen[name] = path.name
|
|
self.assertEqual([], spaced, f"Display names that break a list: {spaced}")
|
|
self.assertEqual([], collisions, f"Ambiguous display names: {collisions}")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|