mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 02:54:26 +00:00
kevinveenbirkenbachandClaude Opus 5
575a5a87ac
Every script a role ships now lives under `files/<language>/`, and the unit
suite is split the same way: `tests/unit/python/` beside new sibling trees for
the other languages. `tests/lint/filesystem/test_role_files_layout.py` keeps it
that way; directories whose shape is dictated from outside carry a `.nocheck`
naming the constraint (Docker build contexts, WordPress mu-plugins, the Joomla
extension, Odoo addons, Playwright suites, the `files/test/test.sh` harness
that `test-e2e-cli` resolves generically).
This cannot be applied in halves. Moving a file and repointing what names it
are the same change: 14 references resolve only at deploy time, so the tree is
green either before or after, never between.
Those 14 were found by static resolution over every reference class, not by the
test suite -- a full `make quality-high` was green while all of them were
broken:
* 7 `src:` values built from a role variable holding a bare filename
(svc-bkp-remote-2-local, decidim, espocrm, friendica, joomla, pixelfed x2).
The variable doubles as the destination name inside the container, so the
language segment belongs at the call site, not in the variable.
* `sys-service/tasks/04_base.yml` resolved every consumer's systemd script
through `first_found(..., errors='strict')` over `files/script.{sh,py}`.
18 roles ship exactly that and have no template fallback: the play would
have died on each.
* `sys-front-inj-javascript` fell back to `<role>/files/javascript.js`; the
interface now reads `files/javascript/javascript.js`.
* `sys-front-inj-logout/templates/head_sub.j2` built the cache-busting mtime
path through `path_absolute(... 'files', ...)`.
* 4 `ansible.builtin.script:` invocations naming a bare command
(pull.py, prune.sh, set_postgres_superuser_password.sh, ganesha-serve.sh).
* `dev-python/files/shell/install.sh` pointed at a sibling role's script.
Depth-dependent paths inside the moved trees were bumped accordingly: 59
`parents[N]` computations, 12 relative climbs, and the per-role recover CLI,
whose path `cli/administration/recover/recoverers.py` still assembled from the
pre-move location.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
93 lines
3.5 KiB
Python
93 lines
3.5 KiB
Python
import tempfile
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from plugins.lookup.cdn import _cdn_paths, _to_url_tree
|
|
|
|
|
|
class TestCdnPaths(unittest.TestCase):
|
|
def setUp(self):
|
|
self.tmp = tempfile.TemporaryDirectory()
|
|
self.root = self.tmp.name
|
|
self.app = "web-app-dashboard"
|
|
self.ver = "latest"
|
|
self.tree = _cdn_paths(self.root, self.app, self.ver)
|
|
|
|
def tearDown(self):
|
|
self.tmp.cleanup()
|
|
|
|
def test_root_is_absolute(self):
|
|
self.assertTrue(Path(self.tree["root"]).is_absolute())
|
|
|
|
def test_shared_paths_under_root(self):
|
|
shared = self.tree["shared"]
|
|
self.assertTrue(shared["css"].startswith(self.tree["root"]))
|
|
self.assertTrue(shared["js"].startswith(self.tree["root"]))
|
|
self.assertTrue(shared["img"].startswith(self.tree["root"]))
|
|
self.assertTrue(shared["fonts"].startswith(self.tree["root"]))
|
|
|
|
def test_vendor_under_root(self):
|
|
self.assertTrue(self.tree["vendor"].startswith(self.tree["root"]))
|
|
|
|
def test_role_id_and_version(self):
|
|
self.assertEqual(self.tree["role"]["id"], self.app)
|
|
self.assertEqual(self.tree["role"]["version"], self.ver)
|
|
|
|
def test_role_release_paths(self):
|
|
release = self.tree["role"]["release"]
|
|
self.assertTrue(release["css"].endswith(str(Path(self.app) / self.ver / "css")))
|
|
self.assertTrue(release["js"].endswith(str(Path(self.app) / self.ver / "js")))
|
|
|
|
def test_different_app_ids_produce_different_role_paths(self):
|
|
other = _cdn_paths(self.root, "web-app-nextcloud", self.ver)
|
|
self.assertNotEqual(
|
|
self.tree["role"]["release"]["css"],
|
|
other["role"]["release"]["css"],
|
|
)
|
|
|
|
|
|
class TestCdnToUrlTree(unittest.TestCase):
|
|
def setUp(self):
|
|
self.tmp = tempfile.TemporaryDirectory()
|
|
self.root = self.tmp.name
|
|
self.base_url = "https://cdn.example.com"
|
|
self.app = "web-app-matomo"
|
|
self.tree = _cdn_paths(self.root, self.app, "latest")
|
|
|
|
def tearDown(self):
|
|
self.tmp.cleanup()
|
|
|
|
def test_paths_become_urls(self):
|
|
urls = _to_url_tree(self.tree, self.root, self.base_url)
|
|
self.assertTrue(urls["shared"]["css"].startswith(self.base_url))
|
|
self.assertTrue(urls["shared"]["js"].startswith(self.base_url))
|
|
self.assertTrue(urls["vendor"].startswith(self.base_url))
|
|
self.assertTrue(urls["role"]["release"]["css"].startswith(self.base_url))
|
|
|
|
def test_root_ends_with_slash(self):
|
|
urls = _to_url_tree(self.tree, self.root, self.base_url)
|
|
self.assertTrue(urls["root"].endswith("/"))
|
|
|
|
def test_non_cdn_strings_unchanged(self):
|
|
urls = _to_url_tree(self.tree, self.root, self.base_url)
|
|
self.assertEqual(urls["role"]["id"], self.app)
|
|
self.assertEqual(urls["role"]["version"], "latest")
|
|
|
|
def test_base_url_trailing_slash_normalized(self):
|
|
urls_with = _to_url_tree(self.tree, self.root, self.base_url + "/")
|
|
urls_without = _to_url_tree(self.tree, self.root, self.base_url)
|
|
self.assertEqual(urls_with["shared"]["css"], urls_without["shared"]["css"])
|
|
|
|
def test_different_apps_produce_different_role_urls(self):
|
|
tree_other = _cdn_paths(self.root, "web-app-nextcloud", "latest")
|
|
urls_a = _to_url_tree(self.tree, self.root, self.base_url)
|
|
urls_b = _to_url_tree(tree_other, self.root, self.base_url)
|
|
self.assertNotEqual(
|
|
urls_a["role"]["release"]["css"],
|
|
urls_b["role"]["release"]["css"],
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|