mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 02:54:26 +00:00
kevinveenbirkenbachandClaude Opus 5
5137465c6f
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
100 lines
3.6 KiB
Python
Executable File
100 lines
3.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from utils.cache.files import iter_project_files
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
|
|
class TestPythonShebangs(unittest.TestCase):
|
|
EXPECTED_PYTHON_SHEBANG = "#!/usr/bin/env python3"
|
|
EXPECTED_ANSIBLE_MODULE_SHEBANG = "#!/usr/bin/python"
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
cls.repo_root = PROJECT_ROOT
|
|
|
|
def _tracked_files(self) -> list[Path]:
|
|
try:
|
|
out = subprocess.check_output(
|
|
["git", "-C", str(self.repo_root), "ls-files", "-z"],
|
|
stderr=subprocess.STDOUT,
|
|
)
|
|
rel_paths = [
|
|
p for p in out.decode("utf-8", errors="replace").split("\0") if p
|
|
]
|
|
return [self.repo_root / p for p in rel_paths]
|
|
except Exception:
|
|
return [Path(p) for p in iter_project_files()]
|
|
|
|
@staticmethod
|
|
def _first_line(path: Path) -> str:
|
|
with path.open("rb") as fh:
|
|
line = fh.readline(4096)
|
|
return line.decode("utf-8", errors="replace").strip()
|
|
|
|
@staticmethod
|
|
def _is_ansible_custom_module(path: Path, repo_root: Path) -> bool:
|
|
rel = path.relative_to(repo_root)
|
|
parts = rel.parts
|
|
if parts[0] == "library" or "library" in parts[1:]:
|
|
return True
|
|
return len(parts) >= 2 and parts[0] == "plugins" and parts[1] == "modules"
|
|
|
|
def test_python_shebangs_are_portable(self):
|
|
portable_violations: list[str] = []
|
|
ansible_module_violations: list[str] = []
|
|
|
|
for path in self._tracked_files():
|
|
if not path.is_file():
|
|
continue
|
|
|
|
first_line = self._first_line(path)
|
|
if not first_line.startswith("#!"):
|
|
continue
|
|
|
|
if "python" not in first_line.lower():
|
|
continue
|
|
|
|
rel = path.relative_to(self.repo_root).as_posix()
|
|
if self._is_ansible_custom_module(path, self.repo_root):
|
|
if first_line != self.EXPECTED_ANSIBLE_MODULE_SHEBANG:
|
|
ansible_module_violations.append(f"{rel}: {first_line}")
|
|
elif first_line != self.EXPECTED_PYTHON_SHEBANG:
|
|
portable_violations.append(f"{rel}: {first_line}")
|
|
|
|
if portable_violations or ansible_module_violations:
|
|
self.fail(
|
|
"Found invalid Python shebangs.\n\n"
|
|
"Why this is necessary:\n"
|
|
"- For normal Python scripts use '#!/usr/bin/env python3' so the interpreter "
|
|
"is resolved via PATH and remains portable across distros/images.\n"
|
|
"- For Ansible custom modules in any `library/` directory keep "
|
|
"'#!/usr/bin/python': Ansible rewrites this interpreter path to the configured "
|
|
"host interpreter.\n"
|
|
"- Using '#!/usr/bin/env python3' in Ansible modules can break execution with "
|
|
"errors like: module interpreter '/usr/bin/env python3' was not found.\n\n"
|
|
+ (
|
|
"Expected '#!/usr/bin/env python3' (non-library Python scripts), but found:\n- "
|
|
+ "\n- ".join(portable_violations)
|
|
+ "\n\n"
|
|
if portable_violations
|
|
else ""
|
|
)
|
|
+ (
|
|
"Expected '#!/usr/bin/python' (Ansible custom modules in library/), but found:\n- "
|
|
+ "\n- ".join(ansible_module_violations)
|
|
if ansible_module_violations
|
|
else ""
|
|
)
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|