mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
5137465c6f
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
40 lines
1.1 KiB
Python
40 lines
1.1 KiB
Python
import re
|
||
import unittest
|
||
|
||
from . import PROJECT_ROOT
|
||
|
||
ROLE_NAME_PATTERN = re.compile(r"^[a-z0-9-]+(?:_[a-z0-9-]+)?$")
|
||
|
||
|
||
class TestRoleNames(unittest.TestCase):
|
||
def test_role_names_follow_naming_convention(self):
|
||
roles_dir = PROJECT_ROOT / "roles"
|
||
self.assertTrue(
|
||
roles_dir.is_dir(), f"'roles/' directory not found at {roles_dir}"
|
||
)
|
||
|
||
invalid_names = []
|
||
|
||
for role_path in roles_dir.iterdir():
|
||
if not role_path.is_dir():
|
||
continue
|
||
|
||
name = role_path.name
|
||
|
||
if name.startswith(".") or name == "__pycache__":
|
||
continue
|
||
|
||
if not ROLE_NAME_PATTERN.fullmatch(name):
|
||
invalid_names.append(name)
|
||
|
||
self.assertFalse(
|
||
invalid_names,
|
||
"The following role directory names violate the naming convention "
|
||
"(only a–z, 0–9, '-', max one '_', and '_' must be followed by at least one character):\n"
|
||
+ "\n".join(f"- {n}" for n in invalid_names),
|
||
)
|
||
|
||
|
||
if __name__ == "__main__":
|
||
unittest.main()
|