Files
computer-playbook/tests/integration/roles/naming/test_folder_names.py
kevinveenbirkenbachandClaude Opus 5 5137465c6f style: delete every comment the comments-valid policy rejects
3529 invalid comments in 528 files, grandfathered in while the linter
only saw the working-tree diff. Removal ran through the linter's own
collectors, so detection and deletion cannot drift: a comment whose
opener line is blank before it and whose closer line is blank after it
loses all its lines, anything else loses only the comment region, and a
line left holding a bare delimiter goes with it.

Five files keep their comments behind a nocheck marker instead. Four are
upstream configs whose inline docs are upstream's own (mautrix, systemd
journald, nextcloud-oidc-login, MediaWiki). In littlejs the
commented-out entries ARE the deactivation mechanism for an example
tile, so deleting them would delete configuration.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-18 03:22:02 +02:00

40 lines
1.1 KiB
Python
Executable File

#!/usr/bin/env python3
import os
import unittest
from pathlib import Path
class TestRolesFolderNames(unittest.TestCase):
def test_no_underscore_in_role_folder_names(self):
"""
Integration test that verifies none of the folders under 'roles' contain an underscore in their name,
ignoring the '__pycache__' folder.
"""
from . import PROJECT_ROOT
roles_dir = str(PROJECT_ROOT / "roles")
entries = []
try:
entries = os.listdir(roles_dir)
except FileNotFoundError:
self.fail(f"Roles directory not found at expected location: {roles_dir}")
invalid = []
for name in entries:
if name == "__pycache__":
continue
path = str(Path(roles_dir) / name)
if Path(path).is_dir() and "_" in name:
invalid.append(name)
if invalid:
self.fail(
f"Role folder names must not contain underscores: {', '.join(sorted(invalid))}"
)
if __name__ == "__main__":
unittest.main()