0 Fork 0

mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2026-11-06 10:59:59 +00:00

Files

T

kevinveenbirkenbachandClaude Opus 4.7 fbecc09d24 refactor(tests): regroup meta tests, add native-metrics contract

- New bidirectional contract test ensures `services.prometheus.native_metrics.enabled`
  and `roles/<role>/templates/prometheus.yml.j2` stay consistent across the roles tree,
  replacing per-role spot checks for gitea/mattermost/matrix. Document the `native-metrics`
  suppression rule and apply it to web-app-mattermost (prepared-but-default-off fragment).
- Move every test in `tests/integration/meta/config/` into the per-domain layout under
  `tests/integration/roles/meta/{services,server}`. Group prometheus tests under
  `services/prometheus/`, repositories tests under `services/repositories/`, the
  `server.csp` shape test under `server/`. Move `test_non_empty.py` one level up
  (scans all meta/*.yml, not just services.yml).
- Delete `tests/integration/meta/spots/` — both files were only `assertIn` over file
  contents (brittle, no behavioural coverage, knowledge belongs in code comments or
  proper integration tests).
- Harden `test_project_root_import.py` to catch chained `Path(__file__)…parent.parent.…`
  walks (the attribute-access twin of `parents[N]` that previously slipped through).
  Refactor 6 surfaced sites to import canonical `PROJECT_ROOT` / `ROLES_DIR`, plus
  delete the now-redundant `_find_roles_dir` / `_find_project_root` helpers in
  `native_metrics_apps` lookup and `invokable_paths` filter plugin.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-17 12:50:35 +02:00

828 B

Raw Permalink Blame History

Prometheus Service Tests 📈

Integration tests that enforce invariants of the prometheus integration: every web-app/svc role declares the shared prometheus service entry, the prometheus role's own nginx + docker-health wiring is intact, and the native-metrics scrape contract (services.prometheus.native_metrics.enabled ⇔ templates/prometheus.yml.j2) holds across the roles tree.

Tests in this directory MUST only cover prometheus-specific wiring and the prometheus service entry. Broader meta/services.yml shape rules MUST live one level up in services/; the ordering-only galaxy_info.run_after cluster lives in run_after/.

For framework, directory layout, and make test-integration usage see integration.md.

828 B Raw Permalink Blame History

Prometheus Service Tests 📈

828 B

Raw Permalink Blame History