mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
5137465c6f
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
42 lines
1.2 KiB
Python
42 lines
1.2 KiB
Python
import re
|
|
import sys
|
|
import unittest
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
ROOT = str(PROJECT_ROOT)
|
|
sys.path.insert(0, ROOT)
|
|
|
|
from cli.meta.roles.applications.all import find_application_ids # noqa: E402
|
|
from utils.cache.files import iter_project_files_with_content # noqa: E402
|
|
|
|
|
|
class TestGroupApplications(unittest.TestCase):
|
|
GROUP_CHECK_RE = re.compile(
|
|
r"['\"](?P<name>[^'\"]+)['\"]\s*(?:in|not in)\s*group_names"
|
|
)
|
|
|
|
def test_group_name_checks_use_valid_application_ids(self):
|
|
"""
|
|
Ensures that any string checked against group_names corresponds to a valid application ID.
|
|
"""
|
|
valid_apps = find_application_ids()
|
|
|
|
for filepath, text in iter_project_files_with_content(
|
|
extensions=(".yml", ".yaml")
|
|
):
|
|
for match in self.GROUP_CHECK_RE.finditer(text):
|
|
name = match.group("name")
|
|
self.assertIn(
|
|
name,
|
|
valid_apps,
|
|
msg=(
|
|
f"{filepath}: group_names check uses '{name}', "
|
|
f"which is not a known application ID {valid_apps}"
|
|
),
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|