mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
5137465c6f
3529 invalid comments in 528 files, grandfathered in while the linter only saw the working-tree diff. Removal ran through the linter's own collectors, so detection and deletion cannot drift: a comment whose opener line is blank before it and whose closer line is blank after it loses all its lines, anything else loses only the comment region, and a line left holding a bare delimiter goes with it. Five files keep their comments behind a nocheck marker instead. Four are upstream configs whose inline docs are upstream's own (mautrix, systemd journald, nextcloud-oidc-login, MediaWiki). In littlejs the commented-out entries ARE the deactivation mechanism for an example tile, so deleting them would delete configuration. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
60 lines
1.8 KiB
Python
60 lines
1.8 KiB
Python
import unittest
|
|
|
|
import yaml
|
|
|
|
from plugins.filter.invokable_paths import get_invokable_paths
|
|
from utils.cache.yaml import load_yaml_any
|
|
from utils.roles.mapping import ROLE_FILE_VARS_MAIN
|
|
|
|
from . import PROJECT_ROOT
|
|
|
|
ROLES_DIR = PROJECT_ROOT / "roles"
|
|
|
|
|
|
class TestApplicationIdConsistency(unittest.TestCase):
|
|
def test_application_id_matches_docker_prefix(self):
|
|
failed_roles = []
|
|
prefixes = get_invokable_paths(suffix="-")
|
|
|
|
for role_path in ROLES_DIR.iterdir():
|
|
if not role_path.is_dir():
|
|
continue
|
|
|
|
role_name = role_path.name
|
|
matching = [p for p in prefixes if role_name.startswith(p)]
|
|
if not matching:
|
|
continue
|
|
|
|
prefix = matching[0]
|
|
expected_id = role_name[len(prefix) :]
|
|
|
|
vars_file = role_path / ROLE_FILE_VARS_MAIN
|
|
if not vars_file.exists():
|
|
failed_roles.append((role_name, "vars/main.yml missing"))
|
|
continue
|
|
|
|
try:
|
|
vars_data = load_yaml_any(str(vars_file)) or {}
|
|
except yaml.YAMLError as e:
|
|
failed_roles.append((role_name, f"YAML error: {e}"))
|
|
continue
|
|
|
|
actual_id = vars_data.get("application_id")
|
|
if actual_id not in [expected_id, role_name]:
|
|
failed_roles.append(
|
|
(
|
|
role_name,
|
|
f"application_id is '{actual_id}', expected '{expected_id}'",
|
|
)
|
|
)
|
|
|
|
if failed_roles:
|
|
msg = "\n".join(f"{r}: {reason}" for r, reason in failed_roles)
|
|
self.fail(
|
|
f"The following roles have mismatching or missing application_id:\n{msg}"
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|