mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
29 lines
1004 B
YAML
29 lines
1004 B
YAML
---
|
|
# Fetch an authenticated REST session and CSRF token for write operations.
|
|
# XWiki REST write requests (PUT/POST/DELETE) may require BOTH:
|
|
# - a valid JSESSIONID cookie
|
|
# - XWiki-Form-Token header
|
|
#
|
|
# This task file sets a fact `xwiki_rest_headers_write` that you can reuse.
|
|
|
|
- name: "⬇️ XWIKI | Fetch REST session + form token (write ops)"
|
|
uri_retry:
|
|
url: "{{ [XWIKI_REST_XWIKI, 'spaces'] | url_join }}"
|
|
method: GET
|
|
url_username: "{{ XWIKI_SUPERADMIN_USERNAME }}"
|
|
url_password: "{{ XWIKI_SUPERADMIN_PASSWORD }}"
|
|
force_basic_auth: true
|
|
status_code: [200]
|
|
return_content: false
|
|
register: _xwiki_rest_session
|
|
changed_when: false
|
|
|
|
- name: "🔧 XWIKI | Set REST write headers"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
set_fact:
|
|
xwiki_rest_headers_write:
|
|
Content-Type: "application/xml"
|
|
Accept: "application/xml"
|
|
Cookie: "{{ _xwiki_rest_session.cookies_string }}"
|
|
XWiki-Form-Token: "{{ _xwiki_rest_session.xwiki_form_token }}"
|