mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
74 lines
2.6 KiB
YAML
74 lines
2.6 KiB
YAML
---
|
|
- name: "✅ ASSERT | superadmin can authenticate (needed for installer)"
|
|
uri_retry:
|
|
url: "{{ [XWIKI_REST_XWIKI, 'spaces'] | url_join }}"
|
|
method: GET
|
|
url_username: "{{ XWIKI_SUPERADMIN_USERNAME }}"
|
|
url_password: "{{ XWIKI_SUPERADMIN_PASSWORD }}"
|
|
force_basic_auth: true
|
|
status_code: [200, 401, 403, 500, 503]
|
|
return_content: true
|
|
register: _super_check_ext
|
|
retries: 120
|
|
delay: 5
|
|
until: _super_check_ext.status == 200
|
|
changed_when: false
|
|
failed_when: false
|
|
|
|
- block:
|
|
- name: "🐛 DEBUG | superadmin check + pw hash compare (condensed)"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
script: >-
|
|
shell/debug_superadmin.sh
|
|
"{{ _super_check_ext.status }}"
|
|
"{{ _super_check_ext.redirected | default('n/a') }}"
|
|
"{{ _super_check_ext.url | default('n/a') }}"
|
|
"{{ _super_check_ext.www_authenticate | default(_super_check_ext.headers['www-authenticate'] | default('n/a')) }}"
|
|
"{{ _super_check_ext.content_type | default(_super_check_ext.headers['content-type'] | default('n/a')) }}"
|
|
"{{ (_super_check_ext.content | default(''))[:600] | replace('\n','\\n') }}"
|
|
"{{ XWIKI_CONTAINER }}"
|
|
"{{ XWIKI_SUPERADMIN_PASSWORD }}"
|
|
register: _dbg_superadmin
|
|
changed_when: false
|
|
failed_when: false
|
|
|
|
- name: "🛑 FAIL | superadmin authentication failed (extensions phase)"
|
|
fail:
|
|
msg: |
|
|
superadmin authentication failed (extensions phase)
|
|
|
|
superadmin check status={{ _super_check_ext.status }}
|
|
www_authenticate={{
|
|
_super_check_ext.www_authenticate
|
|
| default(_super_check_ext.headers['www-authenticate'] | default('n/a'))
|
|
}}
|
|
|
|
debug:
|
|
{{ _dbg_superadmin.stdout | default('') }}
|
|
|
|
hint: check xwiki.cfg in image / password / Dockerfile build
|
|
when: _super_check_ext.status != 200
|
|
|
|
- name: 📂 Load setup procedures for admin
|
|
include_tasks: 03_administrator.yml
|
|
when: not (XWIKI_SSO_ENABLED | bool)
|
|
|
|
- name: 📂 Load setup procedures for extensions
|
|
include_tasks: 04_extensions.yml
|
|
|
|
- name: "✅ XWIKI | Ensure Main.WebHome exists"
|
|
include_tasks: 05_main_webhome.yml
|
|
|
|
- block:
|
|
- name: "📁 Create Final Docker Compose File"
|
|
stack_host_template:
|
|
src: "compose.yml.j2"
|
|
dest: "{{ lookup('container', application_id, 'files.compose') }}"
|
|
notify: compose-up
|
|
|
|
- name: 🚀 Deploy Final Config
|
|
include_tasks: utils/flush_config.yml
|
|
vars:
|
|
xwiki_oidc_enabled_switch: "{{ XWIKI_OIDC_ENABLED | bool }}"
|
|
xwiki_ldap_enabled_switch: "{{ XWIKI_LDAP_ENABLED | bool }}"
|