Files
computer-playbook/roles/web-app-nextcloud/files/playwright/addons/integration_zammad.spec.js
kevinveenbirkenbachandClaude Opus 4.8 4c91df5de7 test(e2e): forbid raw page.goto, migrate all specs to Tor-resilient gotoOnion
New lint test_no_raw_goto.py forbids raw `page.goto(...)` in role playwright specs + persona flows (the gotoOnion wrapper in personas/utils is exempt) so navigation retries transient Tor-transport errors over onion. Migrates every raw call across ~75 roles (343 sites) to `gotoOnion(page, ...)` and teaches gotoOnion to detect relative onion URLs (`isOnionCanonical`). gotoOnion is a behaviour-identical drop-in on clearnet (single attempt, same return). Verified: no-raw-goto lint green, eslint 0 errors, make test green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-08 20:59:38 +02:00

110 lines
4.8 KiB
JavaScript

const { test, expect } = require("@playwright/test");
const { resolveTimeout } = require("../timeouts");
const { skipUnlessAddonEnabled } = require("../addon-gating");
const shared = require("../_shared");
const { gotoOnion } = require("../personas");
test("integration integration_zammad: per-user OAuth connect reaches the partner Zammad authorize endpoint", async ({ browser }) => {
skipUnlessAddonEnabled("integration_zammad");
test.setTimeout(resolveTimeout(120_000));
const context = await browser.newContext({ ignoreHTTPSErrors: true });
const page = await context.newPage();
try {
await shared.loginToStandaloneNextcloud(page);
await gotoOnion(page,
new URL("settings/admin/connected-accounts", shared.env.nextcloudBaseUrl).toString(),
{ waitUntil: "domcontentloaded", timeout: resolveTimeout(60_000) }
);
await shared.dismissBlockingNextcloudModals(page, page);
const zammadPrefs = page.locator("#zammad_prefs");
await expect(
zammadPrefs.first(),
"the Zammad integration admin section (#zammad_prefs) must render when integration_zammad is enabled"
).toBeVisible({ timeout: resolveTimeout(60_000) });
const instanceInput = zammadPrefs
.getByRole("textbox", { name: /zammad instance address/i })
.or(zammadPrefs.locator('input[type="text"], input[type="url"]'));
await expect(
instanceInput.first(),
"the Zammad instance-address field must be present in the admin section"
).toBeVisible({ timeout: resolveTimeout(30_000) });
const instanceUrl = ((await instanceInput.first().inputValue()) || "").trim();
expect(
/^https?:\/\//i.test(instanceUrl),
"oauth_instance_url must be a real partner URL (the addon hook pins it to the partner Zammad base URL)"
).toBeTruthy();
const nextcloudHost = new URL(shared.env.nextcloudBaseUrl).host;
const partnerHost = new URL(instanceUrl).host;
expect(
partnerHost,
"the Zammad instance URL must not point back at Nextcloud itself"
).not.toBe(nextcloudHost);
await gotoOnion(page,
new URL("settings/user/connected-accounts", shared.env.nextcloudBaseUrl).toString(),
{ waitUntil: "domcontentloaded", timeout: resolveTimeout(60_000) }
);
await shared.dismissBlockingNextcloudModals(page, page);
const connect = page
.locator('a[href*="/oauth/authorize"]')
.or(page.getByRole("button", { name: /connect to zammad/i }))
.or(page.getByRole("link", { name: /connect to zammad/i }))
.first();
await expect(
connect,
"the personal 'Connect to Zammad' control must render once the partner OAuth client is provisioned — its absence means the coupling failed to land"
).toBeVisible({ timeout: resolveTimeout(60_000) });
let authorizeHref = await connect.getAttribute("href").catch(() => null);
if (!authorizeHref || !/\/oauth\/authorize/i.test(authorizeHref)) {
// The control is a button doing window.location.replace(<partner>/oauth/authorize?...); Zammad's
// SPA then bounces the unauthenticated browser to login at "/", so the settled URL is no longer the
// authorize endpoint. Capture the authorize request itself — it carries the provisioned client_id.
const requestPromise = page
.waitForRequest((req) => /\/oauth\/authorize/i.test(req.url()), { timeout: resolveTimeout(30_000) })
.catch(() => null);
await connect.click({ timeout: resolveTimeout(10_000) }).catch(() => {});
const request = await requestPromise;
authorizeHref = request ? request.url() : page.url();
}
const authorize = new URL(authorizeHref, instanceUrl);
expect(
authorize.host,
"the Zammad OAuth authorize must be served by the partner instance, not Nextcloud"
).not.toBe(nextcloudHost);
expect(
authorize.host,
"the OAuth authorize host must match the configured partner instance URL"
).toBe(partnerHost);
expect(
authorize.pathname,
"the per-user connect must initiate OAuth on the partner /oauth/authorize endpoint"
).toContain("/oauth/authorize");
const clientId = authorize.searchParams.get("client_id") || "";
expect(
clientId.length,
"the authorize request must carry the provisioned OAuth client_id (proves the partner-registered app)"
).toBeGreaterThan(0);
expect(
clientId.includes("|"),
"the client_id must be the plaintext OAuth uid, not an ICrypto ciphertext - a '|' means integration_zammad read an encrypted value it could not decrypt (NC_ENC_MODE/encryption regression)"
).toBe(false);
expect(
authorize.searchParams.get("response_type"),
"the coupling must use the authorization-code grant"
).toBe("code");
} finally {
await page.close().catch(() => {});
await context.close().catch(() => {});
}
});