Files
computer-playbook/roles/web-app-listmonk/tasks/utils/mcp.yml
kevinveenbirkenbachandClaude Opus 5 791eee7c9f refactor(mcp)!: prove the endpoint contract with a CLI test, not a deploy probe
The contract check ran as an Ansible task in the middle of every provider deploy, and the two client checks ran the same way. A test that is part of the deploy cannot be run without deploying, cannot be re-run on its own, and reports its verdict as a deploy failure. Twenty-seven task files lose 491 lines to this.

It is now what it always was. Each provider ships files/test/test.sh, templates/test.env.j2 and meta/tests.yml, and test-e2e-cli stages one shared harness beside it: run.sh drives contract.sh in a throwaway container on the provider's own network, then isolation.sh for adapter-fronted providers. The read probe each provider offers moved from the calling task into meta/mcp.yml next to the allowlist it must satisfy, and the schema now rejects a read probe naming a tool outside that allowlist.

The bearer the test presents is the one a client resolves through mcp.credential, via the new mcp_client_bearer lookup over resolve_credential, which moved to utils.roles.applications.mcp so it is the same function mcp_servers renders every client connection with. The probe presented whatever the calling role passed, which for the fifteen adapter-fronted providers is a different secret than any client holds.

Sidecar isolation is read from the engine rather than measured inside the container, so it no longer needs a delegation to the node holding the task: attachment is compared by network name, which drops the gwbridge special case, and a swarm worker says it cannot measure instead of skipping silently.

Retrying is bounded by wall clock against MCP_DEADLINE_SECONDS, which scales through the same lookup('timeout') as the harness budget it has to stay under. A flag that is neither true nor false aborts rather than reading as off.

mcp-provider-probe becomes mcp-provider-cli-test: an enabled provider must ship the test rather than include the task. mcp-probe-bearer becomes mcp-adapter-bearer, tying ADAPTER_BEARER to the declared credential key now that no probe include carries it. A new integration test renders the shared env template for every provider through Ansible's own templar, so a later change to it breaks visibly instead of poisoning twenty deploys quietly.

Hermes and OpenClaw keep their client-side proof as CLI tests of their own.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-01 20:46:26 +02:00

50 lines
2.1 KiB
YAML

---
- name: "🧱 Rebuild the MCP adapter of {{ application_id }}"
ansible.builtin.include_tasks: "{{ lookup('path_absolute', 'roles/svc-ai-mcp-adapter/tasks/rebuild.yml') }}"
- name: "🚿 Flush compose handlers for {{ application_id }}"
ansible.builtin.meta: flush_handlers
- name: "🔑 Converge the read-only Listmonk API identity the MCP adapter presents"
ansible.builtin.shell: >-
{{ LISTMONK_EXEC_DATABASE }}
-v role_name={{ LISTMONK_MCP_UPSTREAM_ROLE | quote }}
-v username={{ LISTMONK_MCP_UPSTREAM_USER | quote }}
-v token_hash={{ LISTMONK_MCP_UPSTREAM_KEY | hash('sha256') | quote }}
-v ON_ERROR_STOP=1
-f -
args:
stdin: "{{ lookup('file', 'sql/mcp_identity.sql') }}"
register: listmonk_mcp_identity
changed_when: "'INSERT 0 1' in listmonk_mcp_identity.stdout_lines or 'UPDATE 1' in listmonk_mcp_identity.stdout_lines"
delegate_to: "{{ STACK_HOST }}"
run_once: true
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
- name: "🔍 Resolve {{ application_id }} hosting node + container id"
ansible.builtin.include_tasks: "{{ lookup('path_absolute', 'roles/sys-svc-compose/tasks/utils/swarm/resolve_host_cid.yml') }}"
vars:
resolve_service_key: "listmonk"
resolve_output_prefix: LISTMONK_IDENTITY
resolve_compose_cid: "{{ LISTMONK_NAME }}"
- name: "🔄 Restart Listmonk so it reloads its API user cache"
when: listmonk_mcp_identity.changed
run_once: true
block:
- name: "🔄 compose | restart the Listmonk container"
ansible.builtin.command:
argv:
- container
- restart
- "{{ LISTMONK_IDENTITY_LOCAL_CID }}" # nocheck: container-exec-resolver
changed_when: true
when: DEPLOYMENT_MODE == 'compose'
delegate_to: "{{ LISTMONK_IDENTITY_HOST_NODE }}"
- name: "🔄 swarm | force an update of the Listmonk service"
ansible.builtin.command: "container service update --force {{ lookup('container_service', application_id, 'listmonk') }}"
changed_when: true
timeout: "{{ lookup('timeout', 600) | int }}"
when: DEPLOYMENT_MODE == 'swarm'