mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
20 lines
912 B
YAML
20 lines
912 B
YAML
---
|
|
- name: "✅ Ensure configuration.php DB settings match inventory"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
shell: >
|
|
container exec -i
|
|
-e J_CONFIG_FILE={{ JOOMLA_CONFIG_FILE | quote }}
|
|
-e J_DBTYPE={{ JOOMLA_DB_CONNECTOR | quote }}
|
|
-e J_DBHOST={{ (lookup('database', application_id, 'host') ~ ':' ~ lookup('database', application_id, 'port')) | quote }}
|
|
-e J_DBUSER={{ lookup('database', application_id, 'username') | quote }}
|
|
-e J_DBPASS={{ lookup('database', application_id, 'password') | quote }}
|
|
-e J_DBNAME={{ lookup('database', application_id, 'name') | quote }}
|
|
{{ JOOMLA_LOCAL_CID | quote }} php --
|
|
args:
|
|
stdin: "{{ lookup('file', role_path ~ '/files/php/configure_db.php') }}"
|
|
register: cfg_patch
|
|
changed_when: cfg_patch.stdout == "changed"
|
|
failed_when: cfg_patch.rc != 0
|
|
when: joomla_installed.rc == 0
|
|
delegate_to: "{{ JOOMLA_HOST_NODE }}"
|