mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 19:01:54 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
25 lines
1.2 KiB
YAML
25 lines
1.2 KiB
YAML
---
|
|
- name: "📌 apply outbound Email Account (Mailu SMTP; inbound IMAP deferred)"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
ansible.builtin.shell:
|
|
cmd: > # nocheck: container-exec-resolver runtime-resolved CID, delegated to the hosting node
|
|
container exec -i
|
|
-e SITE_NAME -e MAIL_FROM_NAME -e MAIL_FROM_ADDRESS
|
|
-e SMTP_HOST -e SMTP_PORT -e SMTP_USER -e SMTP_PASS
|
|
{{ ERPNEXT_BACKEND_LOCAL_CID | quote }}
|
|
{{ ERPNEXT_BENCH_PYTHON }}
|
|
stdin: "{{ lookup('ansible.builtin.file', role_path ~ '/files/python/apply/email_account.py') }}"
|
|
delegate_to: "{{ ERPNEXT_BACKEND_HOST_NODE }}"
|
|
environment:
|
|
SITE_NAME: "{{ ERPNEXT_SITE_NAME }}"
|
|
MAIL_FROM_NAME: "{{ ORGANIZATION }} ERPNext"
|
|
MAIL_FROM_ADDRESS: "{{ ERPNEXT_MAIL.username | default('') }}"
|
|
SMTP_HOST: "{{ ERPNEXT_MAIL.host | default('') }}"
|
|
SMTP_PORT: "{{ ERPNEXT_MAIL.port | default(587) }}"
|
|
SMTP_USER: "{{ ERPNEXT_MAIL.username | default('') }}"
|
|
SMTP_PASS: "{{ ERPNEXT_MAIL.password | default('') }}"
|
|
when: ERPNEXT_MAIL.host is defined and (ERPNEXT_MAIL.host | length > 0)
|
|
register: erpnext_email_apply
|
|
changed_when: false
|
|
timeout: "{{ lookup('timeout', 60) | int }}"
|