mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-06 10:59:59 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
61 lines
2.8 KiB
YAML
61 lines
2.8 KiB
YAML
---
|
|
- name: "🔍 probe site_config.json for '{{ ERPNEXT_SITE_NAME }}'"
|
|
ansible.builtin.shell: |
|
|
set -eo pipefail
|
|
# nocheck: container-exec-resolver runtime-resolved CID, delegated to the hosting node
|
|
container exec {{ ERPNEXT_BACKEND_LOCAL_CID | quote }} \
|
|
test -f /home/frappe/frappe-bench/sites/{{ ERPNEXT_SITE_NAME }}/site_config.json
|
|
delegate_to: "{{ ERPNEXT_BACKEND_HOST_NODE }}"
|
|
register: erpnext_site_probe
|
|
changed_when: false
|
|
failed_when: false
|
|
|
|
- name: "🥾 Bootstrap ERPNext site when missing (create + restart + wait for backend)"
|
|
ansible.builtin.include_tasks: 02_bench_bootstrap/create_site.yml
|
|
when: erpnext_site_probe.rc != 0
|
|
|
|
- name: "🔑 Realign the Administrator password with the declared one"
|
|
ansible.builtin.shell: |
|
|
set -euo pipefail
|
|
# nocheck: container-exec-resolver runtime-resolved CID, delegated to the hosting node
|
|
container exec -i -e ADMIN_PASSWORD {{ ERPNEXT_BACKEND_LOCAL_CID | quote }} bash -c '
|
|
bench --site {{ ERPNEXT_SITE_NAME }} set-admin-password "$ADMIN_PASSWORD"
|
|
'
|
|
environment:
|
|
ADMIN_PASSWORD: "{{ ERPNEXT_INITIAL_ADMIN_PASSWORD }}"
|
|
delegate_to: "{{ ERPNEXT_BACKEND_HOST_NODE }}"
|
|
changed_when: true
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
|
|
- name: "✅ ensure encryption_key on site '{{ ERPNEXT_SITE_NAME }}'"
|
|
ansible.builtin.shell: |
|
|
set -euo pipefail
|
|
# nocheck: container-exec-resolver runtime-resolved CID, delegated to the hosting node
|
|
container exec {{ ERPNEXT_BACKEND_LOCAL_CID | quote }} bash -c '
|
|
grep -q "encryption_key" /home/frappe/frappe-bench/sites/{{ ERPNEXT_SITE_NAME }}/site_config.json || \
|
|
bench --site {{ ERPNEXT_SITE_NAME }} execute frappe.utils.password.create_auth_table 2>/dev/null || true
|
|
'
|
|
delegate_to: "{{ ERPNEXT_BACKEND_HOST_NODE }}"
|
|
changed_when: false
|
|
|
|
- name: "📌 apply API-bot user + bypass setup wizard"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
ansible.builtin.shell:
|
|
cmd: > # nocheck: container-exec-resolver runtime-resolved CID, delegated to the hosting node
|
|
container exec -i
|
|
-e SITE_NAME -e API_BOT_LOGIN -e API_BOT_EMAIL -e API_BOT_FIRSTNAME -e API_BOT_LASTNAME -e API_BOT_PASSWORD -e API_KEY_SECRET
|
|
{{ ERPNEXT_BACKEND_LOCAL_CID | quote }}
|
|
{{ ERPNEXT_BENCH_PYTHON }}
|
|
stdin: "{{ lookup('ansible.builtin.file', role_path ~ '/files/python/apply/api_bot.py') }}"
|
|
delegate_to: "{{ ERPNEXT_BACKEND_HOST_NODE }}"
|
|
environment:
|
|
SITE_NAME: "{{ ERPNEXT_SITE_NAME }}"
|
|
API_BOT_LOGIN: "{{ ERPNEXT_API_BOT_USER.username }}"
|
|
API_BOT_EMAIL: "{{ ERPNEXT_API_BOT_USER.email }}"
|
|
API_BOT_FIRSTNAME: "{{ ERPNEXT_API_BOT_USER.firstname }}"
|
|
API_BOT_LASTNAME: "{{ ERPNEXT_API_BOT_USER.lastname }}"
|
|
API_BOT_PASSWORD: "{{ ERPNEXT_API_BOT_PASSWORD }}"
|
|
API_KEY_SECRET: "{{ ERPNEXT_API_KEY_SECRET }}"
|
|
register: erpnext_api_bot_apply
|
|
changed_when: false
|