kevinveenbirkenbachandClaude Opus 5 ea46bf5fde refactor(discourse): drop the plugin repository vars nothing reads ...

DISCOURSE_LDAP_AUTH_PLUGIN_REPOSITORY and DISCOURSE_LDAP_AUTH_PLUGIN_REF date
from fd22d34559, when every role mirrored its git URL into a per-role
REPOSITORY/REF pair. 84a4b04f0 pointed the clone loop in config.yml.j2 at
plugin_config.config.repository and plugin_config.config.ref instead, reading
the addon declaration directly, and left the mirror without a reader.

They are not merely noise. Both are unconditional top-level vars whose
lookup('config', ...) carries no fourth argument and is therefore strict, and
both address a path that exists only while this one addon keeps this one id.
Renaming or removing discourse-ldap-auth would have failed every Discourse task
at resolution time over a value no caller wanted.

The surviving LDAP path is untouched: DISCOURSE_LDAP_ENABLED reads
services.ldap.enabled, and stack_host/02_credentials.yml takes the site
settings through DISCOURSE_PLUGINS['discourse-ldap-auth'].config.site_settings.
A tree-wide grep for DISCOURSE_LDAP_AUTH_PLUGIN now returns nothing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2026-09-14 17:34:23 +02:00

..

main.yml

refactor(discourse): drop the plugin repository vars nothing reads

2026-09-14 17:34:23 +02:00