mirror of
https://github.com/kevinveenbirkenbach/computer-playbook.git
synced 2026-11-07 19:32:17 +00:00
kevinveenbirkenbachandClaude Opus 5
b3ce43a596
At -vvv Ansible prints each module argument and result, so a password in a command line, a request body, a header or a fact lands in the deploy log. Nothing enforced masking outside the MCP task files, and no check looked at parents at all. A new lint, test_credential_tasks_are_masked, finds tasks whose printed parts (module arguments, environment, loop) reference an identifier ending in password, secret, token, api_key or private_key, or secrets.credentials. A task passes when it or an enclosing block sets no_log, when every file that pulls it in does so through include_tasks with apply.no_log or import_tasks with no_log (transitively), when the secret only reaches a parameter the module masks itself, or when the module masks its values. no_log on an include_tasks task itself does not count, because it does not reach the included tasks. The rule can be suppressed per task with `# nocheck: credential-masking`, now listed in the suppression catalog, and the lint tests its parent and suppression logic on synthetic cases. It found 39 unmasked tasks in 19 roles, all real: join tokens, client secrets, API tokens in Cloudflare headers, database passwords in command lines, the ChatGPT bot login body and more. Each now sets no_log from MASK_CREDENTIALS_IN_LOGS. The sys-dns-hetzner-rdns alias hetzner_no_log, which only restated that switch, is gone. Not covered yet: template and copy tasks whose rendered file carries a secret print it as a diff under --diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
97 lines
4.1 KiB
YAML
97 lines
4.1 KiB
YAML
---
|
|
# Cloud flavor (hcloud API)
|
|
- name: 🔍 Resolve effective hcloud token
|
|
set_fact:
|
|
_hz_token: >-
|
|
{{ HETZNER_API_TOKEN
|
|
| default(lookup('env','HETZNER_API_TOKEN'), true)
|
|
| default('', true)
|
|
}}
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
|
|
- name: ✅ Assert hcloud token present
|
|
ansible.builtin.assert:
|
|
that: ["_hz_token | length > 0"]
|
|
fail_msg: "HETZNER_API_TOKEN is required for the Cloud flavor."
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
when: MODE_ASSERT | bool
|
|
|
|
- name: 📊 Collect hcloud servers if needed (server records without identifier)
|
|
hetzner.hcloud.server_info:
|
|
api_token: "{{ _hz_token }}"
|
|
register: _servers_info
|
|
when: rdns_records | selectattr('resource','equalto','server') | selectattr('identifier','undefined') | list | length > 0
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
|
|
- name: 🎬 Init normalized records list
|
|
set_fact:
|
|
_rdns_records: []
|
|
|
|
- name: 📐 Normalize records (autofill server.identifier by IPv4)
|
|
vars:
|
|
_match_name: >-
|
|
{{
|
|
(_servers_info.servers | default([]))
|
|
| selectattr('public_net.ipv4.ip','equalto', rec.ip_address | default(''))
|
|
| map(attribute='name') | list | first | default('')
|
|
}}
|
|
_needs_autofill: >-
|
|
{{
|
|
rec.resource == 'server'
|
|
and (rec.identifier is not defined)
|
|
and (rec.ip_address | default('') | length > 0)
|
|
}}
|
|
_normalized: >-
|
|
{{
|
|
rec if (not _needs_autofill or _match_name == '')
|
|
else (rec | combine({'identifier': _match_name}))
|
|
}}
|
|
set_fact:
|
|
_rdns_records: "{{ _rdns_records + [ _normalized ] }}"
|
|
loop: "{{ rdns_records }}"
|
|
loop_control: { loop_var: rec }
|
|
|
|
- name: ✅ Ensure server identifiers are resolved when required
|
|
assert:
|
|
that:
|
|
- >
|
|
(
|
|
(_rdns_records | selectattr('resource','equalto','server') | selectattr('identifier','defined') | list | length)
|
|
==
|
|
(_rdns_records | selectattr('resource','equalto','server') | list | length)
|
|
)
|
|
fail_msg: "Could not resolve hcloud server by IPv4 for one or more records."
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
when: MODE_ASSERT | bool
|
|
|
|
- name: ✅ Validate records (cloud)
|
|
ansible.builtin.assert:
|
|
that:
|
|
- (_rdns_records | default(rdns_records)) | length > 0
|
|
- (_rdns_records | default(rdns_records)) | selectattr('dns_ptr','defined') | list | length == ((_rdns_records | default(rdns_records)) | length)
|
|
- (_rdns_records | default(rdns_records)) | selectattr('ip_address','defined') | list | length == ((_rdns_records | default(rdns_records)) | length)
|
|
- (_rdns_records | default(rdns_records)) | selectattr('resource','defined') | list | length == ((_rdns_records | default(rdns_records)) | length)
|
|
- ( (_rdns_records | default(rdns_records)) | selectattr('resource','equalto','server') | selectattr('identifier','defined') | list | length +
|
|
((_rdns_records | default(rdns_records)) | rejectattr('resource','equalto','server') | list | length) ) == ((_rdns_records | default(rdns_records)) |
|
|
length)
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|
|
when: MODE_ASSERT | bool
|
|
|
|
- name: 📌 Apply rDNS via hcloud
|
|
hetzner.hcloud.hcloud_rdns:
|
|
api_token: "{{ _hz_token }}"
|
|
server: "{{ (item.resource == 'server') | ternary(item.identifier, omit) }}"
|
|
primary_ip: "{{ (item.resource == 'primary_ip') | ternary(item.identifier, omit) }}"
|
|
floating_ip: "{{ (item.resource == 'floating_ip') | ternary(item.identifier, omit) }}"
|
|
load_balancer: "{{ (item.resource == 'load_balancer') | ternary(item.identifier, omit) }}"
|
|
ip_address: "{{ item.ip_address }}"
|
|
dns_ptr: "{{ item.dns_ptr }}"
|
|
state: present
|
|
loop: "{{ _rdns_records | default(rdns_records) }}"
|
|
loop_control:
|
|
label: "{{ item.resource }}[{{ item.identifier | default('auto-by-ipv4') }}] {{ item.ip_address }} -> {{ item.dns_ptr }}"
|
|
# rationale: async; last task, not delegated, no notify, rDNS is read back by nothing
|
|
async: "{{ hetzner_async_enabled | ternary(hetzner_async_time, omit) }}"
|
|
poll: "{{ hetzner_async_enabled | ternary(hetzner_async_poll, omit) }}"
|
|
no_log: "{{ MASK_CREDENTIALS_IN_LOGS | bool }}"
|