3 Commits

Include renames

Author	SHA1	Message	Date
kevinveenbirkenbachandClaude Opus 5	4ac07edaea	refactor(meta): move the info-media exemption to the file it speaks about ... The marker names the reason a role has no upstream homepage or demo video, and it sat in meta/main.yml because a comment-only info.yml parses to an empty document, which the schema lint rejected outright. So the exemption lived one file away from the two fields it explains, and a reader looking for the video found neither the field nor the reason it was missing. The schema lint now accepts an empty document exactly when it carries the marker, and that is what allows the move. The media lint reads the marker from info.yml rather than main.yml, and its failure message names that same file, so the fix it suggests lands where the absent field would have gone. A hundred and two roles follow. Every occurrence was a standalone comment on the second line of main.yml, directly under the document start, so the move is a line delete and an insert at the same offset. Seventy-three roles already had an info.yml and gain the line; twenty-nine get one whose whole content is the document start and the marker. All hundred and two reasons carry over verbatim, including the thirty-five bespoke ones. Nothing downstream sees a change. Of the four readers of meta/info.yml, three coerce a null parse through `or {}` behind an isinstance guard, and utils/cache/applications.py skips a falsy parse before assignment, so applications.<role>.info stays absent for the twenty-nine exactly as it was while the file did not exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-09-09 22:26:38 +02:00
kevinveenbirkenbachandClaude Opus 4.7	c52e4269bf	chore(tooling): integrate mbake (Makefile linter/formatter) + working-tree drift sync ... Makefile lint integration: * scripts/install/lint.sh: replace the prior checkmake binary install with ensure_mbake (mbake is pip-installable, parses our Makefile correctly whereas checkmake bailed on .ONESHELL: / .SHELLFLAGS: / ifneq). * scripts/lint/makefile.sh: new runner — `mbake format --check Makefile` reports formatting drift and missing .PHONY declarations. * scripts/lint/autoformat.sh: add a two-pass `mbake format Makefile` (mbake's formatter is not strictly idempotent on the first pass). * Makefile: split the multi-line `.PHONY:` block into 18 single-line `.PHONY:` declarations so mbake's parser can validate it; add the previously-missing `install-python-dev` and `build-dependency` PHONY targets; add `lint-makefile` aggregate-and-direct target. * .pre-commit-config.yaml: new make-lint-makefile hook scoped to `^Makefile$`. * .github/workflows/lint-makefile.yml: new CI workflow (pip-install mbake + make lint-makefile). * .github/workflows/ci-orchestrator.yml: wire lint-makefile into lint-gate.needs. Misc: * .gitignore: add roles/importer_result.json (tooling artefact written by galaxy-importer when it runs in roles/). Plus working-tree drift across roles/, group_vars/, inventories/, and tasks/ that accumulated from the make-test setup phase regenerating generated artefacts during recent test runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-09 00:32:44 +02:00
kevinveenbirkenbachandClaude Opus 4.7	b3de2a4d7c	refactor(meta): land req-011 meta/info.yml + utils/cache cleanup ... req-011 — descriptive role-level metadata * Move logo / homepage / video / display out of meta/main.yml.galaxy_info into a new project-owned roles/<role>/meta/info.yml (file-root convention, no `info:` wrapper). * 78 role meta/main.yml files migrated via ruamel round-trip (key-order / quoting / inline-comments preserved). Roles with none of the four fields are left untouched (no empty info.yml created). * web-app-dashboard/lookup_plugins/docker_cards.py reads logo + display from meta/info.yml; description / galaxy_tags continue to come from galaxy_info (Galaxy-spec fields). * docker_cards.py now routes ALL its file reads through the process-wide caches: load_yaml_any for vars/main.yml, meta/main.yml, meta/info.yml; read_text from utils.cache.files for README.md. The orphan `import yaml` is gone. New utils/cache/files (renamed from tests/utils/fs) * The process-wide filesystem cache (read_text, iter_project_files, iter_project_files_with_content, _all_project_files) is not test-specific; it now lives under utils/cache/files.py next to the other process-wide caches. 34 consumer imports rewritten across tests/ and docs/. The empty tests/utils/ package is removed. * New unit suite tests/unit/utils/cache/test_files.py — 12 cases covering read_text, iter_project_files (skip-dirs, extensions, exclude_tests, exclude_dirs, walk-cache invariants), the combined iterator, non-UTF-8 silent skip, and _reset. utils/cache redundancy cleanup * applications.py + users.py + cli/create/inventory/services_disabler.py drop their direct yaml.safe_load calls and their private _load_yaml_mapping/_load_yaml_variant_list copies; everything routes through utils.cache.yaml.load_yaml / load_yaml_any. The dead utils.cache.base._load_yaml_mapping is removed. * users.py:_load_store_users (tokens.yml read) likewise migrated. * _load_yaml_variant_list moves out of base.py to applications.py (its only consumer) and is renamed _load_variants_overrides — also routes through the cached loader now. * utils.cache.yaml._reset_cache_for_tests is renamed _reset (kept as alias) for parity with the per-domain reset helpers. * utils.cache.files grows a _reset() that clears its two LRU caches. * utils.cache.__init__._reset_cache_for_tests now orchestrates ALL six caches (applications, users, domains, base, yaml, files) so tests get clean state across cache layers — needed because applications/users now share the yaml cache and would otherwise serve stale parses across reset boundaries. * utils.cache.files imports PROJECT_ROOT from base instead of redefining it. * tests/unit/utils/cache/test_data.py + test_base.py: obsolete TestLoadYamlMapping / TestLoadYamlVariantList classes deleted (covered by test_yaml.py + test_variants.py). * README.md updated for the new module list (files, yaml) and the six-module orchestrator. Galaxy schema lint * tests/lint/repository/test_role_meta_main_galaxy_schema.py: split galaxy_info field requirements into hard-required {author, description, license} and soft-recommended {min_ansible_version, platforms}. Soft-recommended -> emit a GitHub Actions ::warning:: annotation via utils.annotations.message.warning (titled "meta/main.yml galaxy_info" with file= pointing at the offender), no test failure. Rationale: min_ansible_version + platforms are only enforced by Galaxy when *publishing*, which Infinito.Nexus does not do. * Galaxy lint goes green (was 226 offenders before req-011 + license_url/repository/documentation strip; was 62 before this relaxation; now 0 hard offenders, 62 soft warnings). * roles/svc-opt-keyboard-color/meta/main.yml: backfill `license` (only role missing the hard-required field). New lint * tests/lint/repository/test_role_meta_info.py — enforces meta/info.yml file-root convention, the four-field allowlist (logo, homepage, video, display), and shape (logo.class string, homepage/video non-empty strings, display bool). Also fails if any meta/main.yml.galaxy_info still carries one of the four migrated fields. Docs * docs/contributing/design/services/layout.md: new section "Descriptive Role-Level Metadata — meta/info.yml" with allowed- fields table, optionality rule, materialised path, and consumer note. File-Layout table grows the meta/info.yml row; meta/main.yml row gets the explicit "no logo/homepage/video/display" note. req-011 added to header and Related Pages. * utils/cache/README.md: files.py + yaml.py rows added; six-module reset orchestrator documented. Validation * Unit: 1573 passed. * Lint: 55 passed. * Integration: 161 passed (1 skipped) via pre-commit hook. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-27 12:27:17 +02:00