2 Commits

Include renames

Author	SHA1	Message	Date
kevinveenbirkenbachandClaude Opus 4.7	2a023ca6a1	chore(lint): autoformat strict-failure semantics + claude.sh rename ... * scripts/lint/autoformat.sh: - rename run_sort_claude_settings worker to run_claude (matches the renamed scripts/lint/claude.sh). - drop the EXIT trap that wiped status_dir; cleanup happens explicitly after `wait` returns, so a parallel worker that interrupts the parent never races a vanished status dir. - each worker now captures its tool's exit code and writes one of OK / SKIP / FAIL. Tolerated `expected violations remain`-style exits (markdownlint-cli2 rc≤1, ansible-lint rc≤2) still count as OK; only real failures count as FAIL. - all workers run to completion regardless of individual tool failures (so the user always sees the full picture); after the summary, the script exits 1 if any worker reported FAIL. * scripts/lint/sort_claude_settings.sh -> scripts/lint/claude.sh (history preserved via git mv); update test_claude_settings_sorted.py fix-hint accordingly. Plus working-tree drift across roles/, group_vars/, inventories/, requirements/, and .pre-commit-config.yaml accumulated from the make-test setup phase regenerating generated artefacts during recent test runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-09 01:30:49 +02:00
kevinveenbirkenbachandClaude Opus 4.7	ed04dad5d5	refactor(meta): land req-008/009/010 role-meta layout/networks/ports/run_after migration ... Single atomic landing for three back-to-back role-meta refactor requirements (see docs/requirements/008-role-meta-layout.md, 009-per-role-networks-and-ports.md, 010-role-meta-runafter-lifecycle-migration.md). req-008 — role meta layout * Move every role's metadata under meta/<topic>.yml with file-root convention (no wrapping key matching the basename): - schema/main.yml + config/main.yml.credentials → meta/schema.yml - users/main.yml → meta/users.yml - config/main.yml.server → meta/server.yml - config/main.yml.rbac → meta/rbac.yml - config/main.yml.compose.services + every other top-level key of config/main.yml inlined under <entity>.<key> → meta/services.yml - config/main.yml.compose.volumes → meta/volumes.yml * Drop the legacy schema/, users/, config/ directories from every role. * meta/schema.yml: support nested credential keys, optional `default:` field (Jinja literal, not rendered/validated/regenerated), implicit `algorithm: plain`. * Materialised paths drop the `compose.` prefix: compose.services.<e>.<…> → services.<e>.<…> compose.volumes.<k> → volumes.<k> <former-top-level>.<…> → services.<entity_name>.<former-top-level>.<…> * Update every Python consumer (utils/cache, utils/manager, utils/applications, plugins/lookup, plugins/filter, cli/*) plus every Jinja template, vars/*.yml and task file to the new paths. * No legacy fallback. Repository-wide grep for `compose.services.` / `compose.volumes.` / `schema/main.yml` / `users/main.yml` / `config/main.yml` is empty outside docs/requirements/ and tasks/utils/migrate_meta_layout.py. * Add tests/lint/repository/test_role_meta_layout.py guarding against the old paths returning, and an explicit lint guard that meta/variants.yml files do not carry a `compose:` wrapper. req-009 — per-role networks/ports * Move group_vars/all/08_networks.yml.defaults_networks.local.<role>.{subnet, dns_resolver} into roles/<role>/meta/server.yml.networks.local.{subnet, dns_resolver}. * Delete group_vars/all/09_ports.yml entirely; ports now live on the service entity that exposes them at roles/<role>/meta/services.yml.<entity>.ports.{inter,local,public}. * Rename + int-cast every former top-level `services.<entity>.port` field to `services.<entity>.ports.inter` (single int). * Always-category-keyed maps for ports.local / ports.public; relay spans use {start, end} integers. * Add PORT_BANDS map to group_vars/all/08_networks.yml — single source of truth for the per-<scope>.<category> band ranges, consumed by both the new CLI helpers and the lint test. * New CLI helpers (cli meta ports suggest, cli meta networks suggest) walk the live role tree gap-first then increment-fallback, with deterministic output and non-zero exit on capacity overflow. * cli create role consumes both helpers when scaffolding a new role. * Lint extensions: bare-int port shape rejection, host-bound port collision check (single ints + relay span integers, inter excluded), band-membership check with documented allow-list for the legacy web-app-bigbluebutton.bigbluebutton.local.http: 48087 entry. req-010 — run_after / lifecycle migration * Move galaxy_info.run_after and galaxy_info.lifecycle out of meta/main.yml into meta/services.yml.<primary_entity>.{run_after, lifecycle}; <primary_entity> is the value returned by get_entity_name(role_name). * For multi-entity roles whose primary entity has no compose service (web-app-bluesky → bluesky, web-app-matrix → matrix, desk/dev/drv/ gen roles), create a dedicated metadata-only top-level entry under <primary_entity>. * Introduce utils/roles/meta_lookup.py with get_role_run_after / get_role_lifecycle that resolve <primary_entity> once and read from meta/services.yml; degrade gracefully when meta/services.yml is absent OR the field is absent; raise MetaServicesShapeError when the file exists but is malformed. * Update every consumer (utils/service_registry, utils/invokable, cli/meta/applications/resolution/run_after/__main__, cli/meta/roles/ lifecycle_filter/__main__, cli/meta/applications/resolution/combined, cli/build/{tree,graph,role_include}, cli/deploy/development/{common, init,deps,deploy}, plugins/filter/canonical_domains_map, etc.) to use the helper. * Lint guards: no run_after/lifecycle in meta/main.yml; lifecycle values restricted to {planned,pre-alpha,alpha,beta,stable,deprecated}; run_after/lifecycle never on a non-primary entity; empty run_after lists rejected. Also folded into this change set * services_disabler now writes `services.<svc>.{enabled,shared}` into host_vars instead of the old `compose.services.<svc>.{...}` path; the discover/find pair walks meta/services.yml and only treats entries carrying enabled/shared/provides as provider declarations (so metadata-only entries from req-010 do not create spurious provider rows). * service_registry skips `run_after` deps whose target was filtered out via SERVICES_DISABLED instead of failing the whole load. * cli/mirror/resolver and cli/create/inventory/mirror_overrides emit/ consume the new applications.<role>.services.<svc>.image shape (mirror.md updated to match). * utils/domains/list.build_applications_from_roles now reads meta/server.yml directly (it had been silently returning {} since config/main.yml stopped existing). * utils/roles/resource_validation.filter_roles_by_min_storage reads meta/services.yml.<entity>.min_storage instead of the legacy compose.services path. * web-app-bluesky pre-clones the social-app build context BEFORE sys-svc-compose so the build context is on disk by the time sys-stk-front-proxy/tasks/main.yml flushes the docker build handler. * 4 meta/variants.yml files (svc-ai-ollama, web-app-phpmyadmin, web-app-wordpress, web-app-keycloak) lose their `compose: services:` wrapper so deep-merge over meta/services.yml lands on the new file-root shape. Validation * Unit tests: 1571 passed. * Lint tests: 50 passed. * Integration tests: 161 passed (1 skipped). * Full-cycle fresh-purged-apps deploy succeeded for the 8-app validation set: web-app-{nextcloud,wordpress,yourls,bigbluebutton,bluesky,gitea, discourse,mattermost}. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-27 09:58:26 +02:00