3 Commits

Include renames

Author	SHA1	Message	Date
kevinveenbirkenbachandClaude Fable 5	aedb26eacc	fix(bigbluebutton): pull prebuilt images and align with house patterns ... The freeswitch build fetched libopusenc from launchpad.net, whose librarian backend rate-limits CI (429s across 11 attempts); three more build-time fetches carried the same risk. The maintainer publishes an alangecker/* image for every buildable service, so compose_mods drops build: wherever the service carries an image and compose pulls instead; a guard task fails loudly if a future upstream service still builds. Pin ref to the v3.0.23 release branch (the packaging repo has no tags) and clone it without submodules via the new compose_repository_recursive toggle: submodules only feed build contexts and DEV_MODE mounts, and generate-compose falls back to the committed repos/tags file. Declare the pulled images in meta/services.yml (updater-managed SPOT, mirror pre-pull) and the named data volumes in meta/volumes.yml; the override renders both through the standard container_image / container_volumes / compose_volumes lookups with the service_name pattern. Compose merges volumes by target, so the override's named volumes verifiably replace the clone-local bind mounts (docker compose config proven). This also heals a split-brain mount: apps-akka, periodic and prometheus-exporter previously kept bind mounts while their peers used the named volumes. Teach container_image and compose_volumes to honour compose_mode_force (the SPOT the other mode-aware lookups already read): bbb deploys as a node-local compose stack in swarm, so it must get hub image refs and plain local volumes there, not registry-prefixed refs and NFS driver_opts. The unpinned-engine-volume lint learns the same two safe conditions. Read the embedded Collabora port from web-svc-collabora's services SPOT instead of hardcoding 9980. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 02:37:27 +02:00
kevinveenbirkenbachandClaude Opus 4.7	2a023ca6a1	chore(lint): autoformat strict-failure semantics + claude.sh rename ... * scripts/lint/autoformat.sh: - rename run_sort_claude_settings worker to run_claude (matches the renamed scripts/lint/claude.sh). - drop the EXIT trap that wiped status_dir; cleanup happens explicitly after `wait` returns, so a parallel worker that interrupts the parent never races a vanished status dir. - each worker now captures its tool's exit code and writes one of OK / SKIP / FAIL. Tolerated `expected violations remain`-style exits (markdownlint-cli2 rc≤1, ansible-lint rc≤2) still count as OK; only real failures count as FAIL. - all workers run to completion regardless of individual tool failures (so the user always sees the full picture); after the summary, the script exits 1 if any worker reported FAIL. * scripts/lint/sort_claude_settings.sh -> scripts/lint/claude.sh (history preserved via git mv); update test_claude_settings_sorted.py fix-hint accordingly. Plus working-tree drift across roles/, group_vars/, inventories/, requirements/, and .pre-commit-config.yaml accumulated from the make-test setup phase regenerating generated artefacts during recent test runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-09 01:30:49 +02:00
kevinveenbirkenbachandClaude Opus 4.7	b3de2a4d7c	refactor(meta): land req-011 meta/info.yml + utils/cache cleanup ... req-011 — descriptive role-level metadata * Move logo / homepage / video / display out of meta/main.yml.galaxy_info into a new project-owned roles/<role>/meta/info.yml (file-root convention, no `info:` wrapper). * 78 role meta/main.yml files migrated via ruamel round-trip (key-order / quoting / inline-comments preserved). Roles with none of the four fields are left untouched (no empty info.yml created). * web-app-dashboard/lookup_plugins/docker_cards.py reads logo + display from meta/info.yml; description / galaxy_tags continue to come from galaxy_info (Galaxy-spec fields). * docker_cards.py now routes ALL its file reads through the process-wide caches: load_yaml_any for vars/main.yml, meta/main.yml, meta/info.yml; read_text from utils.cache.files for README.md. The orphan `import yaml` is gone. New utils/cache/files (renamed from tests/utils/fs) * The process-wide filesystem cache (read_text, iter_project_files, iter_project_files_with_content, _all_project_files) is not test-specific; it now lives under utils/cache/files.py next to the other process-wide caches. 34 consumer imports rewritten across tests/ and docs/. The empty tests/utils/ package is removed. * New unit suite tests/unit/utils/cache/test_files.py — 12 cases covering read_text, iter_project_files (skip-dirs, extensions, exclude_tests, exclude_dirs, walk-cache invariants), the combined iterator, non-UTF-8 silent skip, and _reset. utils/cache redundancy cleanup * applications.py + users.py + cli/create/inventory/services_disabler.py drop their direct yaml.safe_load calls and their private _load_yaml_mapping/_load_yaml_variant_list copies; everything routes through utils.cache.yaml.load_yaml / load_yaml_any. The dead utils.cache.base._load_yaml_mapping is removed. * users.py:_load_store_users (tokens.yml read) likewise migrated. * _load_yaml_variant_list moves out of base.py to applications.py (its only consumer) and is renamed _load_variants_overrides — also routes through the cached loader now. * utils.cache.yaml._reset_cache_for_tests is renamed _reset (kept as alias) for parity with the per-domain reset helpers. * utils.cache.files grows a _reset() that clears its two LRU caches. * utils.cache.__init__._reset_cache_for_tests now orchestrates ALL six caches (applications, users, domains, base, yaml, files) so tests get clean state across cache layers — needed because applications/users now share the yaml cache and would otherwise serve stale parses across reset boundaries. * utils.cache.files imports PROJECT_ROOT from base instead of redefining it. * tests/unit/utils/cache/test_data.py + test_base.py: obsolete TestLoadYamlMapping / TestLoadYamlVariantList classes deleted (covered by test_yaml.py + test_variants.py). * README.md updated for the new module list (files, yaml) and the six-module orchestrator. Galaxy schema lint * tests/lint/repository/test_role_meta_main_galaxy_schema.py: split galaxy_info field requirements into hard-required {author, description, license} and soft-recommended {min_ansible_version, platforms}. Soft-recommended -> emit a GitHub Actions ::warning:: annotation via utils.annotations.message.warning (titled "meta/main.yml galaxy_info" with file= pointing at the offender), no test failure. Rationale: min_ansible_version + platforms are only enforced by Galaxy when *publishing*, which Infinito.Nexus does not do. * Galaxy lint goes green (was 226 offenders before req-011 + license_url/repository/documentation strip; was 62 before this relaxation; now 0 hard offenders, 62 soft warnings). * roles/svc-opt-keyboard-color/meta/main.yml: backfill `license` (only role missing the hard-required field). New lint * tests/lint/repository/test_role_meta_info.py — enforces meta/info.yml file-root convention, the four-field allowlist (logo, homepage, video, display), and shape (logo.class string, homepage/video non-empty strings, display bool). Also fails if any meta/main.yml.galaxy_info still carries one of the four migrated fields. Docs * docs/contributing/design/services/layout.md: new section "Descriptive Role-Level Metadata — meta/info.yml" with allowed- fields table, optionality rule, materialised path, and consumer note. File-Layout table grows the meta/info.yml row; meta/main.yml row gets the explicit "no logo/homepage/video/display" note. req-011 added to header and Related Pages. * utils/cache/README.md: files.py + yaml.py rows added; six-module reset orchestrator documented. Validation * Unit: 1573 passed. * Lint: 55 passed. * Integration: 161 passed (1 skipped) via pre-commit hook. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-27 12:27:17 +02:00