kevinveenbirkenbach/computer-playbook
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2025-12-20 07:43:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: remove unused variables in module_utils and tests

Browse Source 
https://chatgpt.com/share/6942c80f-c904-800f-8793-f804da1aa891
This commit is contained in:
Kevin Veen-Birkenbach
2025-12-17 16:10:58 +01:00
parent 9f76946735
commit ee3e86684a
7 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/integration/test_unnecessary_role_dependencies.py
View File

@@ -247,16 +247,12 @@ class TestUnnecessaryRoleDependencies(unittest.TestCase):
# --- 2) Task-level analysis
any_usage = False
any_bad_order = False
any_include_somewhere = False
for path, text in task_texts:
if not text:
continue
include_off = first_include_offset_for_role(text, producer)
if include_off is not None:
any_include_somewhere = True
var_use_off = first_var_use_offset_in_text(text, provided_vars)
notify_offs = find_notify_offsets_for_handlers(text, provider_handlers)
@@ -277,14 +273,12 @@ class TestUnnecessaryRoleDependencies(unittest.TestCase):
if not any_bad_order:
if not any_usage:
reason = "no variable/handler usage detected in consumer"
suggest = "remove from meta/dependencies; include only where needed (optionally guarded)."
warnings.append(
f"[{consumer}] meta dependency on '{producer}' appears unnecessary: {reason}."
)
else:
# Usage exists but guarded by include in each file
reason = "all usages occur after include/import in the same task file"
suggest = "remove from meta/dependencies; keep the explicit include/import (guard with run_once_* if global)."
warnings.append(
f"[{consumer}] meta dependency on '{producer}' appears unnecessary: {reason}."
)