kevinveenbirkenbach/computer-playbook
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2025-12-03 07:59:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix variable definition test: ignore boolean keywords (not/and/or) and detect bare vars in YAML list expressions. See ChatGPT conversation: https://chatgpt.com/share/692c693b-9958-800f-a815-6c15ca045108

Browse Source
This commit is contained in:
Kevin Veen-Birkenbach
2025-11-30 16:57:07 +01:00
parent 007963044b
commit e6d6cb639c
1 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/integration/test_variable_definitions.py
View File

@@ -75,6 +75,11 @@ class TestVariableDefinitions(unittest.TestCase):
self.mapping_key = re.compile(r'^\s*([a-zA-Z_]\w*)\s*:\s*') self.mapping_key = re.compile(r'^\s*([a-zA-Z_]\w*)\s*:\s*')
self.register_pat = re.compile(r'^\s*register\s*:\s*([a-zA-Z_]\w*)') self.register_pat = re.compile(r'^\s*register\s*:\s*([a-zA-Z_]\w*)')
# Bare vars in YAML list expressions wie:
# - SOME_VAR | bool
# - OTHER_VAR | length > 0
self.bare_list_expr_var = re.compile(r'^\s*-\s*([a-zA-Z_]\w*)\b')
# ----------------------- # -----------------------
# Collect "defined" names # Collect "defined" names
# ----------------------- # -----------------------
@@ -239,6 +244,32 @@ class TestVariableDefinitions(unittest.TestCase):
undefined_uses.append( undefined_uses.append(
f"{path}:{lineno}: '{{{{ {var} }}}}' used but not defined" f"{path}:{lineno}: '{{{{ {var} }}}}' used but not defined"
) )
# Handle bare vars in list expressions, e.g.:
# - SYSTEMD_MANAGER_RESET_PURGE | bool
stripped = line.lstrip()
# Heuristic: "- VAR | ..." but not a mapping ("key: value")
if stripped.startswith('- ') and '|' in stripped and ':' not in stripped:
m_expr = self.bare_list_expr_var.match(stripped)
if m_expr:
var = m_expr.group(1)
if var not in (
'lookup', 'role_name', 'domains', 'item', 'host_type',
'inventory_hostname', 'role_path', 'playbook_dir',
'ansible_become_password', 'inventory_dir',
'ansible_memtotal_mb', 'omit', 'group_names',
'ansible_processor_vcpus', 'not', 'and', 'or',
):
if (
var not in self.defined
and f"default_{var}" not in self.defined
and f"defaults_{var}" not in self.defined
):
undefined_uses.append(
f"{path}:{lineno}: bare var '{var}' used but not defined"
)
except Exception: except Exception:
pass pass