fix(bigbluebutton): resolve CodeQL useless-assignment alerts #260 #261

Remove useless assignments to changed before the unconditional
changed = true at the password block. Also fix ||= short-circuit bug
that skipped ensure_attr! when changed was already true.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

roles/web-app-bigbluebutton/files/greenlight_ensure_admin.rb

@@ -50,13 +50,12 @@ if user
     changed = true
   end
 
-  changed ||= ensure_attr!(user, :provider, "greenlight")
-  changed ||= ensure_attr!(user, :language, "en")
+  ensure_attr!(user, :provider, "greenlight")
+  ensure_attr!(user, :language, "en")
 
   if user.respond_to?(:role=) && user.respond_to?(:role_id)
     if user.role_id != admin_role.id
       user.role = admin_role
-      changed = true
     end
   end