kevinveenbirkenbach/computer-playbook
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2025-08-26 21:45:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Optimized message

Browse Source
This commit is contained in:
Kevin Veen-Birkenbach 2025-08-20 01:03:07 +02:00
parent 3794aa87b0
commit d7ece2a8c3
No known key found for this signature in database
GPG Key ID: 44D8F11FD62F878E
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
cli/build/role_include.py
View File

@ -102,8 +102,10 @@ def find_cycle(roles):
def topological_sort(graph, in_degree, roles=None): def topological_sort(graph, in_degree, roles=None):
""" """
Perform topological sort on the dependency graph. Perform topological sort on the dependency graph.
If `roles` is provided, on error it will include detailed debug info. If a cycle is detected, raise an Exception with detailed debug info.
""" """
from collections import deque
queue = deque([r for r, d in in_degree.items() if d == 0]) queue = deque([r for r, d in in_degree.items() if d == 0])
sorted_roles = [] sorted_roles = []
local_in = dict(in_degree) local_in = dict(in_degree)
@ -117,28 +119,26 @@ def topological_sort(graph, in_degree, roles=None):
queue.append(nbr) queue.append(nbr)
if len(sorted_roles) != len(in_degree): if len(sorted_roles) != len(in_degree):
# Something went wrong: likely a cycle
cycle = find_cycle(roles or {}) cycle = find_cycle(roles or {})
if roles is not None: unsorted = [r for r in in_degree if r not in sorted_roles]
if cycle:
header = f"Circular dependency detected: {' -> '.join(cycle)}"
else:
header = "Circular dependency detected among the roles!"
unsorted = [r for r in in_degree if r not in sorted_roles] header = "❌ Dependency resolution failed"
detail_lines = ["Unsorted roles and their dependencies:"] if cycle:
reason = f"Circular dependency detected: {' -> '.join(cycle)}"
else:
reason = "Unresolved dependencies among roles (possible cycle or missing role)."
details = []
if unsorted:
details.append("Unsorted roles and their declared run_after dependencies:")
for r in unsorted: for r in unsorted:
deps = roles.get(r, {}).get('run_after', []) deps = roles.get(r, {}).get('run_after', [])
detail_lines.append(f" - {r} depends on {deps!r}") details.append(f" - {r} depends on {deps!r}")
detail_lines.append("Full dependency graph:") graph_repr = f"Full dependency graph: {dict(graph)!r}"
detail_lines.append(f" {dict(graph)!r}")
raise Exception("\n".join([header] + detail_lines)) raise Exception("\n".join([header, reason] + details + [graph_repr]))
else:
if cycle:
raise Exception(f"Circular dependency detected: {' -> '.join(cycle)}")
else:
raise Exception("Circular dependency detected among the roles!")
return sorted_roles return sorted_roles