Optimized inventory validator for wrong groups

tests/integration/test_cli_help.py

@@ -34,7 +34,7 @@ class CLIHelpIntegrationTest(unittest.TestCase):
                     segments = rel_dir.split(os.sep) + [cmd_name]
 
                 with self.subTest(command=' '.join(segments)):
-                    cmd = [self.python, self.main_py] + segments + ['--help']
+                    cmd = [self.python, self.main_py] + segments + ['--help', '--no-signal']
                     result = subprocess.run(
                         cmd, capture_output=True, text=True
                     )

tests/unit/cli/validate/test_inventory_hosts.py

@@ -0,0 +1,71 @@
+import os
+import re
+import yaml
+import tempfile
+import shutil
+import unittest
+from unittest.mock import patch
+
+# Module under test
+import cli.validate.inventory as inventory_mod
+
+class TestValidateHostKeys(unittest.TestCase):
+    def setUp(self):
+        # Create a temporary directory for servers.yml
+        self.test_dir = tempfile.mkdtemp()
+        # Patch find_application_ids to a fixed set
+        self.valid_ids = {'valid-service', 'another-service'}
+        patcher = patch.object(inventory_mod, 'find_application_ids', return_value=self.valid_ids)
+        self.mock_find_ids = patcher.start()
+        self.addCleanup(patcher.stop)
+
+    def tearDown(self):
+        shutil.rmtree(self.test_dir)
+
+    def write_servers_yaml(self, groups):
+        # Build the YAML structure
+        content = {'all': {'children': {}}}
+        for group, hosts in groups.items():
+            # hosts is a list of hostnames
+            content['all']['children'][group] = {'hosts': {h: None for h in hosts}}
+        path = os.path.join(self.test_dir, 'servers.yml')
+        with open(path, 'w', encoding='utf-8') as f:
+            yaml.safe_dump(content, f)
+        return path
+
+    def test_no_invalid_groups(self):
+        # All groups valid
+        groups = {
+            'valid-service': ['host1'],
+            'another-service': ['host2', 'host3']
+        }
+        self.write_servers_yaml(groups)
+        errors = inventory_mod.validate_host_keys(self.valid_ids, self.test_dir)
+        self.assertEqual(errors, [], f"Expected no errors, got {errors}")
+
+    def test_single_invalid_group(self):
+        # One invalid group
+        groups = {
+            'valid-service': ['host1'],
+            'invalid-service': ['host2']
+        }
+        self.write_servers_yaml(groups)
+        errors = inventory_mod.validate_host_keys(self.valid_ids, self.test_dir)
+        self.assertEqual(len(errors), 1)
+        self.assertRegex(errors[0], r"Invalid group 'invalid-service'.*not in application_ids")
+
+    def test_multiple_invalid_groups(self):
+        # Multiple invalid groups
+        groups = {
+            'bad-one': ['h1'],
+            'bad-two': ['h2'],
+            'valid-service': ['h3']
+        }
+        self.write_servers_yaml(groups)
+        errors = inventory_mod.validate_host_keys(self.valid_ids, self.test_dir)
+        self.assertEqual(len(errors), 2)
+        found = {re.search(r"Invalid group '(.+?)'", e).group(1) for e in errors}
+        self.assertSetEqual(found, {'bad-one', 'bad-two'})
+
+if __name__ == '__main__':
+    unittest.main()

tests/unit/filter_plugins/test_get_domain.py

@@ -1,4 +1,3 @@
-# tests/unit/test_get_domain.py
 import unittest
 import sys
 import os