kevinveenbirkenbach/computer-playbook
1
0
Fork 0
mirror of https://github.com/kevinveenbirkenbach/computer-playbook.git synced 2025-08-29 15:06:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

Added validation for get_domain calls

Browse Source
This commit is contained in:
Kevin Veen-Birkenbach
2025-07-11 03:05:41 +02:00
parent 7fba13b550
commit 691b204512
5 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/integration/test_valid_applications.py
View File

@@ -13,12 +13,14 @@ class TestValidApplicationUsage(unittest.TestCase):
"""
Integration test to ensure that only valid application IDs
are used in all .yml, .yaml, .yml.j2, .yaml.j2, and .py files.
Methods like applications.items() can be whitelisted and ignored.
Methods like applications.items() and calls to get_domain() can
be whitelisted or validated against valid IDs.
"""
# regex patterns to capture applications['name'], applications.get('name'), and applications.name
# regex patterns to capture applications['name'], applications.get('name'), applications.name, and get_domain('name')
APPLICATION_SUBSCRIPT_RE = re.compile(r"applications\[['\"](?P<name>[^'\"]+)['\"]\]")
APPLICATION_GET_RE = re.compile(r"applications\.get\(\s*['\"](?P<name>[^'\"]+)['\"]")
APPLICATION_ATTR_RE = re.compile(r"applications\.(?P<name>[A-Za-z_]\w*)")
APPLICATION_DOMAIN_RE = re.compile(r"get_domain\(\s*['\"](?P<name>[^'\"]+)['\"]\s*\)")
# methods and exceptions that should not be validated as application IDs
WHITELIST = {'items', 'yml', 'get'}
@@ -47,6 +49,7 @@ class TestValidApplicationUsage(unittest.TestCase):
self.APPLICATION_SUBSCRIPT_RE,
self.APPLICATION_GET_RE,
self.APPLICATION_ATTR_RE,
self.APPLICATION_DOMAIN_RE,
):
for match in pattern.finditer(content):
name = match.group('name')