In between commit domain restruturing

tests/unit/test_domain_filters.py

@@ -0,0 +1,123 @@
+import os
+import sys
+import unittest
+
+# Add the filter_plugins directory to the import path
+dir_path = os.path.abspath(
+    os.path.join(os.path.dirname(__file__), '../../filter_plugins')
+)
+sys.path.insert(0, dir_path)
+
+from ansible.errors import AnsibleFilterError
+from domain_filters import FilterModule
+
+class TestDomainFilters(unittest.TestCase):
+    def setUp(self):
+        self.filter_module = FilterModule()
+        # Sample primary domain
+        self.primary = 'example.com'
+
+    def test_canonical_empty_apps(self):
+        apps = {}
+        expected = {}
+        result = self.filter_module.canonical_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_canonical_without_domains(self):
+        apps = {'app1': {}}
+        expected = {'app1': ['app1.example.com']}
+        result = self.filter_module.canonical_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_canonical_with_list(self):
+        apps = {
+            'app1': {
+                'domains': {'canonical': ['foo.com', 'bar.com']}
+            }
+        }
+        result = self.filter_module.canonical_domains_map(apps, self.primary)
+        self.assertCountEqual(result['app1'], ['foo.com', 'bar.com'])
+
+    def test_canonical_with_dict(self):
+        apps = {
+            'app1': {
+                'domains': {'canonical': {'one': 'one.com', 'two': 'two.com'}}
+            }
+        }
+        result = self.filter_module.canonical_domains_map(apps, self.primary)
+        self.assertCountEqual(result['app1'], ['one.com', 'two.com'])
+
+    def test_canonical_duplicate_raises(self):
+        apps = {
+            'app1': {'domains': {'canonical': ['dup.com']}},
+            'app2': {'domains': {'canonical': ['dup.com']}},
+        }
+        with self.assertRaises(AnsibleFilterError) as cm:
+            self.filter_module.canonical_domains_map(apps, self.primary)
+        self.assertIn("configured for both", str(cm.exception))
+
+    def test_alias_empty_apps(self):
+        apps = {}
+        expected = {}
+        result = self.filter_module.alias_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_alias_without_aliases_and_no_canonical(self):
+        apps = {'app1': {}}
+        # canonical defaults to ['app1.example.com'], so alias should be []
+        expected = {'app1': []}
+        result = self.filter_module.alias_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_alias_with_explicit_aliases(self):
+        apps = {
+            'app1': {
+                'domains': {'aliases': ['alias.com']}
+            }
+        }
+        # canonical defaults to ['app1.example.com'], so alias should include alias.com and default
+        expected = {'app1': ['alias.com', 'app1.example.com']}
+        result = self.filter_module.alias_domains_map(apps, self.primary)
+        self.assertCountEqual(result['app1'], expected['app1'])
+
+    def test_alias_with_canonical_not_default(self):
+        apps = {
+            'app1': {
+                'domains': {'canonical': ['foo.com']}
+            }
+        }
+        # foo.com is canonical, default not in canonical so added as alias
+        expected = {'app1': ['app1.example.com']}
+        result = self.filter_module.alias_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_alias_with_existing_default(self):
+        apps = {
+            'app1': {
+                'domains': {
+                    'canonical': ['foo.com'],
+                    'aliases': ['app1.example.com']
+                }
+            }
+        }
+        # default present in aliases, should not be duplicated
+        expected = {'app1': ['app1.example.com']}
+        result = self.filter_module.alias_domains_map(apps, self.primary)
+        self.assertEqual(result, expected)
+
+    def test_invalid_canonical_type(self):
+        apps = {
+            'app1': {'domains': {'canonical': 123}}
+        }
+        with self.assertRaises(AnsibleFilterError):
+            self.filter_module.canonical_domains_map(apps, self.primary)
+
+    def test_invalid_aliases_type(self):
+        apps = {
+            'app1': {'domains': {'aliases': 123}}
+        }
+        with self.assertRaises(AnsibleFilterError):
+            self.filter_module.alias_domains_map(apps, self.primary)
+
+if __name__ == "__main__":
+    unittest.main()

tests/unit/test_generate_default_applications.py

@@ -23,7 +23,7 @@ class TestGenerateDefaultApplications(unittest.TestCase):
         (self.sample_role / "vars" / "configuration.yml").write_text("foo: bar\nbaz: 123\n")
 
         # Output file path
-        self.output_file = self.temp_dir / "group_vars" / "all" / "11_applications.yml"
+        self.output_file = self.temp_dir / "group_vars" / "all" / "03_applications.yml"
 
     def tearDown(self):
         shutil.rmtree(self.temp_dir)