From edf0a34e5936df1bf34496e53c55bc5b5744d779 Mon Sep 17 00:00:00 2001
From: Kevin Frantz <mail@kevin-frantz.de>
Date: Sun, 6 Jan 2019 20:03:28 +0100
Subject: [PATCH] Implemented draft for CRUD management

---
 .../Controller/API/APIControllerInterface.php | 19 -------
 .../Controller/API/AbstractAPIController.php  | 20 +++++---
 .../API/CRUDControllerInterface.php           | 47 ------------------
 .../API/Meta/HeredityApiController.php        |  8 ++-
 .../Controller/API/Meta/LawApiController.php  |  4 +-
 .../API/Meta/MemberApiController.php          |  8 ++-
 .../API/Meta/RightApiController.php           |  8 ++-
 .../API/Source/SourceApiController.php        | 49 ++++++++++++-------
 .../AbstractSecureCRUD.php                    | 11 +++++
 .../Create/AbstractSecureCreator.php          | 11 +++++
 .../Create/SecureCreatorInterface.php         | 19 +++++++
 .../Create/SecureSourceCreator.php            | 28 +++++++++++
 .../Create/SecureSourceCreatorInterface.php   | 11 +++++
 .../SecureCRUDFactoryService.php              | 42 ++++++++++++++++
 .../SecureCRUDInterface.php                   | 12 +++++
 .../API/Source/SourceControllerTest.php       | 28 +++++++++++
 16 files changed, 232 insertions(+), 93 deletions(-)
 delete mode 100644 application/symfony/src/Controller/API/APIControllerInterface.php
 delete mode 100644 application/symfony/src/Controller/API/CRUDControllerInterface.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/AbstractSecureCRUD.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/Create/AbstractSecureCreator.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/Create/SecureCreatorInterface.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreator.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreatorInterface.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDFactoryService.php
 create mode 100644 application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDInterface.php
 create mode 100644 application/symfony/tests/Unit/Controller/API/Source/SourceControllerTest.php

diff --git a/application/symfony/src/Controller/API/APIControllerInterface.php b/application/symfony/src/Controller/API/APIControllerInterface.php
deleted file mode 100644
index 134d247..0000000
--- a/application/symfony/src/Controller/API/APIControllerInterface.php
+++ /dev/null
@@ -1,19 +0,0 @@
-<?php
-
-namespace App\Controller\API;
-
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
-
-/**
- * @author kevinfrantz
- */
-interface APIControllerInterface
-{
-    /**
-     * @param Request $request HTTP Method GET with filtering parameters
-     *
-     * @return Response
-     */
-    public function list(Request $request): Response;
-}
diff --git a/application/symfony/src/Controller/API/AbstractAPIController.php b/application/symfony/src/Controller/API/AbstractAPIController.php
index 13960ce..ea47d57 100644
--- a/application/symfony/src/Controller/API/AbstractAPIController.php
+++ b/application/symfony/src/Controller/API/AbstractAPIController.php
@@ -5,21 +5,22 @@ namespace App\Controller\API;
 use App\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
 
 /**
  * @author kevinfrantz
+ * @todo Implement!
  * @see https://de.wikipedia.org/wiki/CRUD
  */
-abstract class AbstractAPIController extends AbstractController implements APIControllerInterface
+abstract class AbstractAPIController extends AbstractController
 {
-
     /**
      * @param Request $request HTTP Method POST with the object attributes as parameters
      *
      * @return Response
      */
-    abstract public function create(Request $request): Response;
-    
+    abstract public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response;
+
     /**
      * @param Request    $request    HTTP Method GET
      * @param int|string $identifier The slug or id of the object
@@ -27,7 +28,7 @@ abstract class AbstractAPIController extends AbstractController implements APICo
      * @return Response
      */
     abstract public function read(Request $request, $identifier): Response;
-    
+
     /**
      * @param Request    $request    HTTP Method PUT
      * @param int|string $identifier The slug or id of the object
@@ -35,7 +36,7 @@ abstract class AbstractAPIController extends AbstractController implements APICo
      * @return Response
      */
     abstract public function update(Request $request, $identifier): Response;
-    
+
     /**
      * @param Request    $request    HTTP Method DELETE with the object attributes as parameters
      * @param int|string $identifier The slug or id of the object
@@ -43,4 +44,11 @@ abstract class AbstractAPIController extends AbstractController implements APICo
      * @return Response
      */
     abstract public function delete(Request $request, $identifier): Response;
+
+    /**
+     * @param Request $request HTTP Method GET with filtering parameters
+     *
+     * @return Response
+     */
+    abstract public function list(Request $request): Response;
 }
diff --git a/application/symfony/src/Controller/API/CRUDControllerInterface.php b/application/symfony/src/Controller/API/CRUDControllerInterface.php
deleted file mode 100644
index 5e7692c..0000000
--- a/application/symfony/src/Controller/API/CRUDControllerInterface.php
+++ /dev/null
@@ -1,47 +0,0 @@
-<?php
-
-namespace App\Controller\API;
-
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpFoundation\Request;
-
-/**
- * Moved functions to
- * @see AbstractAPIController
- * @author kevinfrantz
- * @deprecated Feel free to delete this interface!
- * @see https://de.wikipedia.org/wiki/CRUD
- */
-interface CRUDControllerInterface
-{
-    /**
-     * @param Request $request HTTP Method POST with the object attributes as parameters
-     *
-     * @return Response
-     */
-    public function create(Request $request): Response;
-
-    /**
-     * @param Request    $request    HTTP Method GET
-     * @param int|string $identifier The slug or id of the object
-     *
-     * @return Response
-     */
-    public function read(Request $request, $identifier): Response;
-
-    /**
-     * @param Request    $request    HTTP Method PUT
-     * @param int|string $identifier The slug or id of the object
-     *
-     * @return Response
-     */
-    public function update(Request $request, $identifier): Response;
-
-    /**
-     * @param Request    $request    HTTP Method DELETE with the object attributes as parameters
-     * @param int|string $identifier The slug or id of the object
-     *
-     * @return Response
-     */
-    public function delete(Request $request, $identifier): Response;
-}
diff --git a/application/symfony/src/Controller/API/Meta/HeredityApiController.php b/application/symfony/src/Controller/API/Meta/HeredityApiController.php
index ae0c607..b33a76d 100644
--- a/application/symfony/src/Controller/API/Meta/HeredityApiController.php
+++ b/application/symfony/src/Controller/API/Meta/HeredityApiController.php
@@ -5,14 +5,20 @@ namespace App\Controller\API\Meta;
 use App\Controller\API\AbstractAPIController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
 
+/**
+ * 
+ * @author kevinfrantz
+ * @todo Implement!
+ */
 class HeredityApiController extends AbstractAPIController
 {
     public function read(Request $request, $identifier): Response
     {
     }
 
-    public function create(Request $request): Response
+    public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response
     {
     }
 
diff --git a/application/symfony/src/Controller/API/Meta/LawApiController.php b/application/symfony/src/Controller/API/Meta/LawApiController.php
index f638fab..67483a9 100644
--- a/application/symfony/src/Controller/API/Meta/LawApiController.php
+++ b/application/symfony/src/Controller/API/Meta/LawApiController.php
@@ -5,9 +5,11 @@ namespace App\Controller\API\Meta;
 use App\Controller\API\AbstractAPIController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
 
 /**
  * @author kevinfrantz
+ * @todo Implement!
  */
 class LawApiController extends AbstractAPIController
 {
@@ -15,7 +17,7 @@ class LawApiController extends AbstractAPIController
     {
     }
 
-    public function create(Request $request): Response
+    public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response
     {
     }
 
diff --git a/application/symfony/src/Controller/API/Meta/MemberApiController.php b/application/symfony/src/Controller/API/Meta/MemberApiController.php
index 418e16a..35b84e0 100644
--- a/application/symfony/src/Controller/API/Meta/MemberApiController.php
+++ b/application/symfony/src/Controller/API/Meta/MemberApiController.php
@@ -5,14 +5,20 @@ namespace App\Controller\API\Meta;
 use App\Controller\API\AbstractAPIController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
 
+/**
+ * 
+ * @author kevinfrantz
+ * @todo Implement!
+ */
 class MemberApiController extends AbstractAPIController
 {
     public function read(Request $request, $identifier): Response
     {
     }
 
-    public function create(Request $request): Response
+    public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response
     {
     }
 
diff --git a/application/symfony/src/Controller/API/Meta/RightApiController.php b/application/symfony/src/Controller/API/Meta/RightApiController.php
index 7e0949d..2413834 100644
--- a/application/symfony/src/Controller/API/Meta/RightApiController.php
+++ b/application/symfony/src/Controller/API/Meta/RightApiController.php
@@ -5,14 +5,20 @@ namespace App\Controller\API\Meta;
 use App\Controller\API\AbstractAPIController;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
 
+/**
+ * 
+ * @author kevinfrantz
+ * @todo Implement!
+ */
 class RightApiController extends AbstractAPIController
 {
     public function read(Request $request, $identifier): Response
     {
     }
 
-    public function create(Request $request): Response
+    public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response
     {
     }
 
diff --git a/application/symfony/src/Controller/API/Source/SourceApiController.php b/application/symfony/src/Controller/API/Source/SourceApiController.php
index 4ea1d08..fea4561 100644
--- a/application/symfony/src/Controller/API/Source/SourceApiController.php
+++ b/application/symfony/src/Controller/API/Source/SourceApiController.php
@@ -7,9 +7,12 @@ use Symfony\Component\Routing\Annotation\Route;
 use Symfony\Component\HttpFoundation\Request;
 use App\Controller\API\AbstractAPIController;
 use App\Entity\Source\PureSource;
+use App\Domain\SecureCRUDManagement\SecureCRUDFactoryService;
+use App\Domain\SecureCRUDManagement\Create\SecureSourceCreatorInterface;
 
 /**
  * @author kevinfrantz
+ * @todo Implement!
  */
 class SourceApiController extends AbstractAPIController
 {
@@ -20,7 +23,7 @@ class SourceApiController extends AbstractAPIController
      * )
      * {@inheritdoc}
      *
-     * @see \App\Controller\API\CRUDControllerInterface::read()
+     * @see \App\Controller\API\AbstractAPIController::read()
      */
     public function read(Request $request, $identifier): Response
     {
@@ -33,31 +36,43 @@ class SourceApiController extends AbstractAPIController
      * )
      * {@inheritdoc}
      *
-     * @see \App\Controller\API\CRUDControllerInterface::create()
+     * @see \App\Controller\API\AbstractAPIController::create()
      */
-    public function create(Request $request): Response
+    public function create(Request $request, SecureCRUDFactoryService $crudFactory): Response
     {
+        $response = new Response();
+        if (!$this->getUser()) {
+            //throw $this->createAccessDeniedException('The user must be logged in!');
+        }
+
         if (Request::METHOD_POST === $request->getMethod()) {
             $response = new Response();
             $response->setContent('Post Request!');
 
             return $response;
         }
-
-        $response = new Response();
-        $response->setContent('GET Request!');
+        /**
+         * @var SecureSourceCreatorInterface
+         */
+        $sourceCreator = $crudFactory->create();
+        $response->setContent($sourceCreator->create()->getText());
 
         return $response;
 
-        $requestedSource = new PureSource();
-        $requestedSource->setSlug(SystemSlugType::IMPRINT);
-        $requestedRight = new Right();
-        $requestedRight->setSource($requestedSource);
-        $requestedRight->setLayer(LayerType::SOURCE);
-        $requestedRight->setType(CRUDType::READ);
-        $sourceResponseManager = new SourceRESTResponseManager($this->getUser(), $entityManager, $requestedRight, $this->getViewHandler());
+//         $response = new Response();
+//         $response->setContent('GET Request!');
 
-        return $sourceResponseManager->getResponse();
+//         return $response;
+
+//         $requestedSource = new PureSource();
+//         $requestedSource->setSlug(SystemSlugType::IMPRINT);
+//         $requestedRight = new Right();
+//         $requestedRight->setSource($requestedSource);
+//         $requestedRight->setLayer(LayerType::SOURCE);
+//         $requestedRight->setType(CRUDType::READ);
+//         $sourceResponseManager = new SourceRESTResponseManager($this->getUser(), $entityManager, $requestedRight, $this->getViewHandler());
+
+//         return $sourceResponseManager->getResponse();
     }
 
     /**
@@ -67,7 +82,7 @@ class SourceApiController extends AbstractAPIController
      * )
      * {@inheritdoc}
      *
-     * @see \App\Controller\API\CRUDControllerInterface::update()
+     * @see \App\Controller\API\AbstractAPIController::update()
      */
     public function update(Request $request, $identifier): Response
     {
@@ -80,7 +95,7 @@ class SourceApiController extends AbstractAPIController
      * )
      * {@inheritdoc}
      *
-     * @see \App\Controller\API\APIControllerInterface::list()
+     * @see \App\Controller\API\AbstractAPIController::list()
      */
     public function list(Request $request): Response
     {
@@ -93,7 +108,7 @@ class SourceApiController extends AbstractAPIController
      * )
      * {@inheritdoc}
      *
-     * @see \App\Controller\API\CRUDControllerInterface::delete()
+     * @see \App\Controller\API\AbstractAPIController::delete()
      */
     public function delete(Request $request, $identifier): Response
     {
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/AbstractSecureCRUD.php b/application/symfony/src/Domain/SecureCRUDManagement/AbstractSecureCRUD.php
new file mode 100644
index 0000000..34a7d61
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/AbstractSecureCRUD.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement;
+
+/**
+ * @author kevinfrantz
+ * @todo Implement!
+ */
+abstract class AbstractSecureCRUD implements SecureCRUDInterface
+{
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/Create/AbstractSecureCreator.php b/application/symfony/src/Domain/SecureCRUDManagement/Create/AbstractSecureCreator.php
new file mode 100644
index 0000000..3c2d86e
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/Create/AbstractSecureCreator.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement\Create;
+
+/**
+ * @author kevinfrantz
+ * @todo Implement!
+ */
+abstract class AbstractSecureCreator implements SecureCreatorInterface
+{
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureCreatorInterface.php b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureCreatorInterface.php
new file mode 100644
index 0000000..5411401
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureCreatorInterface.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement\Create;
+
+use App\Domain\SecureCRUDManagement\SecureCRUDInterface;
+use App\Entity\EntityInterface;
+
+/**
+ * @todo Implement!
+ * @author kevinfrantz
+ *
+ */
+interface SecureCreatorInterface extends SecureCRUDInterface
+{
+    /**
+     * @return EntityInterface The created entity
+     */
+    public function create(): EntityInterface;
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreator.php b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreator.php
new file mode 100644
index 0000000..440b6b5
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreator.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement\Create;
+
+use App\Entity\EntityInterface;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Security\Core\Security;
+use App\Entity\Source\Primitive\Text\TextSource;
+
+/**
+ * @author kevinfrantz
+ *
+ * @todo Implement!
+ */
+class SecureSourceCreator extends AbstractSecureCreator implements SecureSourceCreatorInterface
+{
+    public function __construct(Request $request, Security $security)
+    {
+    }
+
+    public function create(): EntityInterface
+    {
+        $source = new TextSource();
+        $source->setText('Hello World!');
+
+        return $source;
+    }
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreatorInterface.php b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreatorInterface.php
new file mode 100644
index 0000000..5166ac7
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/Create/SecureSourceCreatorInterface.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement\Create;
+
+/**
+ * @author kevinfrantz
+ * @todo Implement!
+ */
+interface SecureSourceCreatorInterface extends SecureCreatorInterface
+{
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDFactoryService.php b/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDFactoryService.php
new file mode 100644
index 0000000..59c8f8d
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDFactoryService.php
@@ -0,0 +1,42 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement;
+
+use App\Entity\Meta\RightInterface;
+use App\Domain\SecureCRUDManagement\Create\SecureSourceCreator;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\Security\Core\Security;
+use Symfony\Component\HttpFoundation\RequestStack;
+
+/**
+ * 
+ * @author kevinfrantz
+ * @todo Implement!
+ * @todo substitute through child classes!
+ */
+class SecureCRUDFactoryService
+{
+    /**
+     * @var Request
+     */
+    private $request;
+
+    /**
+     * @var Security
+     */
+    private $security;
+
+    public function __construct(RequestStack $requestStack, Security $security)
+    {
+        $this->request = $requestStack->getCurrentRequest();
+        $this->security = $security;
+    }
+
+    /**
+     * @param RightInterface $requestedRight
+     */
+    public function create(?RightInterface $requestedRight = null)
+    {
+        return new SecureSourceCreator($this->request, $this->security);
+    }
+}
diff --git a/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDInterface.php b/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDInterface.php
new file mode 100644
index 0000000..3f143bd
--- /dev/null
+++ b/application/symfony/src/Domain/SecureCRUDManagement/SecureCRUDInterface.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace App\Domain\SecureCRUDManagement;
+
+/**
+ * @todo Implement!
+ * @author kevinfrantz
+ *
+ */
+interface SecureCRUDInterface
+{
+}
diff --git a/application/symfony/tests/Unit/Controller/API/Source/SourceControllerTest.php b/application/symfony/tests/Unit/Controller/API/Source/SourceControllerTest.php
new file mode 100644
index 0000000..a10f33e
--- /dev/null
+++ b/application/symfony/tests/Unit/Controller/API/Source/SourceControllerTest.php
@@ -0,0 +1,28 @@
+<?php
+
+namespace tests\Unit\Controller\API\Source;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\HttpFoundation\Request;
+
+class SourceControllerTest extends KernelTestCase
+{
+    public function setUp(): void
+    {
+        self::bootKernel();
+    }
+
+    /**
+     * @todo Optimize test!
+     */
+    public function testCreate(): void
+    {
+        $url = '/en/api/source.json';
+        $request = new Request([], [], [], [], [], [
+            'REQUEST_URI' => $url,
+        ]);
+        $request->setMethod(Request::METHOD_GET);
+        $response = static::$kernel->handle($request);
+        $this->assertEquals(200, $response->getStatusCode());
+    }
+}