From ed41dd6bf85c459617b24b903aa53c8ec3fd1d4c Mon Sep 17 00:00:00 2001
From: Kevin Frantz <mail@kevin-frantz.de>
Date: Sat, 24 Nov 2018 14:59:15 +0100
Subject: [PATCH] Implemenented version attribt, repository and tests for right
 entity

---
 .../src/Entity/Attribut/PriorityAttribut.php  |  21 ++++
 .../Attribut/PriorityAttributInterface.php    |  10 ++
 application/src/Entity/Meta/Reciever.php      |   2 +-
 application/src/Entity/Meta/Right.php         |  13 ++-
 .../src/Entity/Meta/RightInterface.php        |   3 +-
 .../src/Repository/RightRepository.php        |  12 +++
 .../Entity/Attribut/PriorityAttributTest.php  |  38 +++++++
 .../tests/Unit/Entity/Meta/RightTest.php      |   1 +
 .../Unit/Repository/RightRepositoryTest.php   | 100 ++++++++++++++++++
 9 files changed, 196 insertions(+), 4 deletions(-)
 create mode 100644 application/src/Entity/Attribut/PriorityAttribut.php
 create mode 100644 application/src/Entity/Attribut/PriorityAttributInterface.php
 create mode 100644 application/src/Repository/RightRepository.php
 create mode 100644 application/tests/Unit/Entity/Attribut/PriorityAttributTest.php
 create mode 100644 application/tests/Unit/Repository/RightRepositoryTest.php

diff --git a/application/src/Entity/Attribut/PriorityAttribut.php b/application/src/Entity/Attribut/PriorityAttribut.php
new file mode 100644
index 0000000..6e4be76
--- /dev/null
+++ b/application/src/Entity/Attribut/PriorityAttribut.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace App\Entity\Attribut;
+
+trait PriorityAttribut
+{
+    /**
+     * @var int
+     */
+    protected $priority;
+
+    public function setPriority(int $priority): void
+    {
+        $this->priority = $priority;
+    }
+
+    public function getPriority(): int
+    {
+        return $this->priority;
+    }
+}
diff --git a/application/src/Entity/Attribut/PriorityAttributInterface.php b/application/src/Entity/Attribut/PriorityAttributInterface.php
new file mode 100644
index 0000000..57a052c
--- /dev/null
+++ b/application/src/Entity/Attribut/PriorityAttributInterface.php
@@ -0,0 +1,10 @@
+<?php
+
+namespace App\Entity\Attribut;
+
+interface PriorityAttributInterface
+{
+    public function setPriority(int $priority): void;
+
+    public function getPriority(): int;
+}
diff --git a/application/src/Entity/Meta/Reciever.php b/application/src/Entity/Meta/Reciever.php
index 881eba7..533d6d5 100644
--- a/application/src/Entity/Meta/Reciever.php
+++ b/application/src/Entity/Meta/Reciever.php
@@ -21,7 +21,7 @@ class Reciever extends AbstractMeta implements RecieverInterface
      * The right which the reciever group belongs to.
      *
      * @ORM\OneToOne(targetEntity="Right",cascade={"persist", "remove"})
-     * @ORM\JoinColumn(name="right_id", referencedColumnName="id")
+     * @ORM\JoinColumn(name="right_id", referencedColumnName="id",onDelete="CASCADE")
      *
      * @var RightInterface
      */
diff --git a/application/src/Entity/Meta/Right.php b/application/src/Entity/Meta/Right.php
index 2a3263e..25b4902 100644
--- a/application/src/Entity/Meta/Right.php
+++ b/application/src/Entity/Meta/Right.php
@@ -14,6 +14,7 @@ use App\Entity\Attribut\ConditionAttribut;
 use App\Entity\Attribut\RecieverAttribut;
 use App\Entity\Attribut\LayerAttribut;
 use App\Entity\Attribut\RelationAttribut;
+use App\Entity\Attribut\PriorityAttribut;
 
 /**
  * @author kevinfrantz
@@ -22,7 +23,14 @@ use App\Entity\Attribut\RelationAttribut;
  */
 class Right extends AbstractMeta implements RightInterface
 {
-    use TypeAttribut,LawAttribut, RelationAttribut, GrantAttribut,ConditionAttribut,RecieverAttribut,LayerAttribut;
+    use TypeAttribut,LawAttribut, RelationAttribut, GrantAttribut,ConditionAttribut,RecieverAttribut,LayerAttribut,PriorityAttribut;
+
+    /**
+     * @ORM\Column(type="integer")
+     *
+     * @var int which priority has the right in a roleset
+     */
+    protected $priority;
 
     /**
      * @ORM\ManyToOne(targetEntity="Law", inversedBy="rights")
@@ -42,7 +50,7 @@ class Right extends AbstractMeta implements RightInterface
 
     /**
      * @ORM\OneToOne(targetEntity="Reciever",cascade={"persist", "remove"})
-     * @ORM\JoinColumn(name="reciever_id", referencedColumnName="id")
+     * @ORM\JoinColumn(name="reciever_id", referencedColumnName="id",onDelete="CASCADE")
      *
      * @var RecieverInterface
      */
@@ -75,6 +83,7 @@ class Right extends AbstractMeta implements RightInterface
     {
         parent::__construct();
         $this->grant = true;
+        $this->priority = 0;
         $this->reciever = new Reciever();
         $this->reciever->setRight($this);
     }
diff --git a/application/src/Entity/Meta/RightInterface.php b/application/src/Entity/Meta/RightInterface.php
index 57ae557..f4207b1 100644
--- a/application/src/Entity/Meta/RightInterface.php
+++ b/application/src/Entity/Meta/RightInterface.php
@@ -9,10 +9,11 @@ use App\Entity\Attribut\GrantAttributInterface;
 use App\Entity\Attribut\ConditionAttributInterface;
 use App\Entity\Attribut\LayerAttributInterface;
 use App\Entity\Attribut\RelationAttributInterface;
+use App\Entity\Attribut\PriorityAttributInterface;
 
 /**
  * @author kevinfrantz
  */
-interface RightInterface extends TypeAttributInterface, LawAttributInterface, GrantAttributInterface, RecieverAttributInterface, RelationAttributInterface, ConditionAttributInterface, LayerAttributInterface, MetaInterface
+interface RightInterface extends TypeAttributInterface, LawAttributInterface, GrantAttributInterface, RecieverAttributInterface, RelationAttributInterface, ConditionAttributInterface, LayerAttributInterface, MetaInterface, PriorityAttributInterface
 {
 }
diff --git a/application/src/Repository/RightRepository.php b/application/src/Repository/RightRepository.php
new file mode 100644
index 0000000..83e8bf7
--- /dev/null
+++ b/application/src/Repository/RightRepository.php
@@ -0,0 +1,12 @@
+<?php
+
+namespace App\Repository;
+
+use Doctrine\ORM\EntityRepository;
+
+/**
+ * @author kevinfrantz
+ */
+class RightRepository extends EntityRepository
+{
+}
diff --git a/application/tests/Unit/Entity/Attribut/PriorityAttributTest.php b/application/tests/Unit/Entity/Attribut/PriorityAttributTest.php
new file mode 100644
index 0000000..867a8ef
--- /dev/null
+++ b/application/tests/Unit/Entity/Attribut/PriorityAttributTest.php
@@ -0,0 +1,38 @@
+<?php
+
+namespace Tests\Unit\Entity\Attribut;
+
+use PHPUnit\Framework\TestCase;
+use App\Entity\Attribut\PriorityAttributInterface;
+use App\Entity\Attribut\PriorityAttribut;
+
+/**
+ * @author kevinfrantz
+ */
+class PriorityAttributTest extends TestCase
+{
+    /**
+     * @var PriorityAttributInterface
+     */
+    protected $priorityAttribut;
+
+    public function setUp(): void
+    {
+        $this->priorityAttribut = new class() implements PriorityAttributInterface {
+            use PriorityAttribut;
+        };
+    }
+
+    public function testConstructor(): void
+    {
+        $this->expectException(\TypeError::class);
+        $this->priorityAttribut->getPriority();
+    }
+
+    public function testAccessors(): void
+    {
+        $priority = 123;
+        $this->assertNull($this->priorityAttribut->setPriority($priority));
+        $this->assertEquals($priority, $this->priorityAttribut->getPriority());
+    }
+}
diff --git a/application/tests/Unit/Entity/Meta/RightTest.php b/application/tests/Unit/Entity/Meta/RightTest.php
index c2182d6..4076ecc 100644
--- a/application/tests/Unit/Entity/Meta/RightTest.php
+++ b/application/tests/Unit/Entity/Meta/RightTest.php
@@ -29,6 +29,7 @@ class RightTest extends TestCase
     {
         $this->assertEquals($this->right, $this->right->getReciever()->getRight());
         $this->assertTrue($this->right->getGrant());
+        $this->assertEquals(0, $this->right->getPriority());
     }
 
     public function testConstructorLayer(): void
diff --git a/application/tests/Unit/Repository/RightRepositoryTest.php b/application/tests/Unit/Repository/RightRepositoryTest.php
new file mode 100644
index 0000000..8ab0189
--- /dev/null
+++ b/application/tests/Unit/Repository/RightRepositoryTest.php
@@ -0,0 +1,100 @@
+<?php
+
+namespace tests\Unit\Repository;
+
+use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Doctrine\ORM\EntityManager;
+use Doctrine\ORM\EntityRepository;
+use App\Entity\Meta\RightInterface;
+use App\Entity\Meta\Right;
+use App\DBAL\Types\LayerType;
+use App\DBAL\Types\RightType;
+use App\Entity\Meta\Law;
+use App\Entity\Meta\LawInterface;
+
+/**
+ * @todo specify tests for all attributes
+ *
+ * @author kevinfrantz
+ */
+class RightRepositoryTest extends KernelTestCase
+{
+    const PRIORITY = 123;
+
+    /**
+     * @var EntityManager
+     */
+    protected $entityManager;
+
+    /**
+     * @var EntityRepository
+     */
+    protected $rightRepository;
+
+    /**
+     * @var RightInterface
+     */
+    protected $loadedRight;
+
+    /**
+     * @var RightInterface
+     */
+    protected $right;
+
+    /**
+     * @var LawInterface
+     */
+    protected $law;
+
+    public function setUp(): void
+    {
+        $kernel = self::bootKernel();
+        $this->entityManager = $kernel->getContainer()
+            ->get('doctrine')
+            ->getManager();
+        $this->rightRepository = $this->entityManager->getRepository(Right::class);
+        $this->right = new Right();
+        $this->right->setPriority(self::PRIORITY);
+        $this->right->setLayer(LayerType::SOURCE);
+        $this->right->setType(RightType::READ);
+        $this->law = new Law();
+        $this->entityManager->persist($this->law);
+        $this->right->setLaw($this->law);
+    }
+
+    public function testCreation(): void
+    {
+        $this->entityManager->persist($this->right);
+        $this->entityManager->flush();
+        $rightId = $this->right->getId();
+        /*
+         * @var RightInterface
+         */
+        $this->loadedRight = $this->rightRepository->find($rightId);
+        $this->assertEquals($rightId, $this->loadedRight->getId());
+        $this->assertEquals(self::PRIORITY, $this->loadedRight->getPriority());
+        $this->deleteRight();
+        $this->assertNull($this->rightRepository->find($rightId));
+        $this->loadedRight = null;
+    }
+
+    private function deleteRight(): void
+    {
+        $this->entityManager->remove($this->loadedRight);
+        $this->entityManager->flush();
+        $this->entityManager->remove($this->law);
+        $this->entityManager->flush();
+    }
+
+    /**
+     * {@inheritdoc}
+     *
+     * @see \Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::tearDown()
+     */
+    protected function tearDown(): void
+    {
+        parent::tearDown();
+        $this->entityManager->close();
+        $this->entityManager = null;
+    }
+}