From 4a40f78e7d6c8a5b5abd6ae47b478edd4790549a Mon Sep 17 00:00:00 2001 From: Kevin Frantz Date: Fri, 18 Jan 2019 18:12:31 +0100 Subject: [PATCH] Added comments --- .../LawPermissionCheckerService.php | 8 +++++++ .../Domain/RightManagement/RightChecker.php | 21 +++++++++++++++++++ .../RightManagement/RightCheckerInterface.php | 10 +++++++++ .../SourceMemberInformation.php | 6 ++++++ 4 files changed, 45 insertions(+) diff --git a/application/symfony/src/Domain/LawManagement/LawPermissionCheckerService.php b/application/symfony/src/Domain/LawManagement/LawPermissionCheckerService.php index 6dab096..47d7bb6 100644 --- a/application/symfony/src/Domain/LawManagement/LawPermissionCheckerService.php +++ b/application/symfony/src/Domain/LawManagement/LawPermissionCheckerService.php @@ -142,11 +142,19 @@ final class LawPermissionCheckerService implements LawPermissionCheckerServiceIn return $rightChecker->isGranted($client->getLayer(), $client->getCrud(), $client->getReciever()); } + /** + * @param LawInterface $law + */ public function __construct(LawInterface $law) { $this->law = $law; } + /** + * {@inheritdoc} + * + * @see \App\Domain\LawManagement\LawPermissionCheckerServiceInterface::hasPermission() + */ public function hasPermission(RightInterface $clientRight): bool { $rights = clone $this->law->getRights(); diff --git a/application/symfony/src/Domain/RightManagement/RightChecker.php b/application/symfony/src/Domain/RightManagement/RightChecker.php index 3217ef0..0ffa386 100644 --- a/application/symfony/src/Domain/RightManagement/RightChecker.php +++ b/application/symfony/src/Domain/RightManagement/RightChecker.php @@ -33,26 +33,47 @@ final class RightChecker implements RightCheckerInterface return $allSourcesToWhichRightApplies; } + /** + * @param SourceInterface $clientSource + * + * @return bool + */ private function hasClientSource(SourceInterface $clientSource): bool { return $this->getAllSourcesToWhichRightApplies()->contains($clientSource); } + /** + * @param string $layer + * + * @return bool + */ private function isLayerEqual(string $layer): bool { return $this->right->getLayer() === $layer; } + /** + * @param string $type + * + * @return bool + */ private function isTypeEqual(string $type): bool { return $this->right->getCrud() === $type; } + /** + * @return bool + */ private function checkPermission(): bool { return $this->right->getGrant(); } + /** + * @param RightInterface $right + */ public function __construct(RightInterface $right) { $this->right = $right; diff --git a/application/symfony/src/Domain/RightManagement/RightCheckerInterface.php b/application/symfony/src/Domain/RightManagement/RightCheckerInterface.php index bc00fdb..af962d3 100644 --- a/application/symfony/src/Domain/RightManagement/RightCheckerInterface.php +++ b/application/symfony/src/Domain/RightManagement/RightCheckerInterface.php @@ -4,7 +4,17 @@ namespace App\Domain\RightManagement; use App\Entity\Source\SourceInterface; +/** + * @author kevinfrantz + */ interface RightCheckerInterface { + /** + * @param string $layer + * @param string $type + * @param SourceInterface $source + * + * @return bool + */ public function isGranted(string $layer, string $type, SourceInterface $source): bool; } diff --git a/application/symfony/src/Domain/SourceManagement/SourceMemberInformation.php b/application/symfony/src/Domain/SourceManagement/SourceMemberInformation.php index e6d4501..568d7f3 100644 --- a/application/symfony/src/Domain/SourceManagement/SourceMemberInformation.php +++ b/application/symfony/src/Domain/SourceManagement/SourceMemberInformation.php @@ -7,6 +7,9 @@ use App\Entity\Source\SourceInterface; use Doctrine\Common\Collections\ArrayCollection; use App\Entity\Meta\Relation\Member\MemberRelationInterface; +/** + * @author kevinfrantz + */ final class SourceMemberInformation implements SourceMemberInformationInterface { /** @@ -19,6 +22,9 @@ final class SourceMemberInformation implements SourceMemberInformationInterface */ private $members; + /** + * @param SourceInterface $source + */ public function __construct(SourceInterface $source) { $this->source = $source;