From f714f9b57c9174ae48dc2f984d809fb0da98742f Mon Sep 17 00:00:00 2001 From: "Kevin Veen-Birkenbach [aka. Frantz]" Date: Sun, 11 Oct 2020 20:48:55 +0200 Subject: [PATCH] Optimized --- scripts/backup.sh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/scripts/backup.sh b/scripts/backup.sh index 614b65f..d8b5fdd 100644 --- a/scripts/backup.sh +++ b/scripts/backup.sh @@ -3,17 +3,18 @@ host_backup_folder_path="$HOME/Backup/docker/" docker_backup_folder_path="/Backup/docker/" mkdir -p "$host_backup_folder_path" backup_folders=("/var/www/html/" "/var/lib/mysql/"); -for docker_container_id in $(docker ps -q); +for docker_container_name in $(docker ps --format '{{.Names}}'); do - #backup_dir_base_path="$docker_backup_folder_path""archive/$(date '+%Y%m%d%H%M%S')/""$docker_container_id/" - echo "stop container: $docker_container_id" && docker stop "$docker_container_id" + #backup_dir_base_path="$docker_backup_folder_path""archive/$(date '+%Y%m%d%H%M%S')/""$docker_container_name/" + echo "stop container: $docker_container_name" && docker stop "$docker_container_name" for rsync_source_path in "${backup_folders[@]}"; do - rsync_destination_path="$docker_backup_folder_path""last/""$docker_container_id$rsync_source_path"; + rsync_docker_destination_path="$docker_backup_folder_path""last/""$docker_container_name$rsync_source_path"; #backup_dir_path="$backup_dir_base_path$rsync_source_path"; echo "trying to backup $rsync_source_path..." - mkdir -p "$HOME$rsync_destination_path" - docker run --rm --volumes-from "$docker_container_id" -v "$host_backup_folder_path:$docker_backup_folder_path" "kevinveenbirkenbach/alpine-rsync" rsync -a --delete $rsync_source_path $rsync_destination_path + $rsync_host_destination_path="$HOME$rsync_docker_destination_path"; + mkdir -p $rsync_host_destination_path; + docker run --rm --volumes-from "$docker_container_name" -v "$host_backup_folder_path:$docker_backup_folder_path" "kevinveenbirkenbach/alpine-rsync" rsync -a --delete $rsync_source_path $rsync_docker_destination_path || rmdir $rsync_host_destination_path; done - echo "start container: $docker_container_id" && docker start "$docker_container_id" + echo "start container: $docker_container_name" && docker start "$docker_container_name" done