From e8992f254c49d67882df896fc634536cbf8fa740 Mon Sep 17 00:00:00 2001
From: Kevin Veen-Birkenbach <kevin@veen.world>
Date: Sun, 13 Jul 2025 16:55:08 +0200
Subject: [PATCH] Solved bugs identified during unit test

---
 roles/desk-chromium/config/main.yml           | 22 ++++++++++++++++++
 .../templates/configuration.yml.j2            | 23 -------------------
 .../templates/extensions_policy.json.j2       |  4 ++--
 3 files changed, 24 insertions(+), 25 deletions(-)
 create mode 100644 roles/desk-chromium/config/main.yml
 delete mode 100644 roles/desk-chromium/templates/configuration.yml.j2

diff --git a/roles/desk-chromium/config/main.yml b/roles/desk-chromium/config/main.yml
new file mode 100644
index 00000000..ac27c89e
--- /dev/null
+++ b/roles/desk-chromium/config/main.yml
@@ -0,0 +1,22 @@
+# Concerning configuration options checkout:
+# https://chromeenterprise.google/policies/#ExtensionSettings
+password_manager_enabled: false
+default_installation_mode: allowed
+plugins:
+  # UBlock Origin
+  - id: "cjpalhdlnbpafiamejdnhcphjbkeiagm"
+    update_url: "https://clients2.google.com/service/update2/crx"
+    incognito: true
+    installation_mode: "force_installed"
+
+  # KeepassXC
+  - id: "ddkjiahejlhfcafbddmgiahcphecmpfh"
+    update_url: "https://clients2.google.com/service/update2/crx"
+    incognito: false
+    installation_mode: "force_installed"
+
+  # Dark Mode Extension
+  - id: "dmghijelimhndkbmpgbldicpogfkceaj"
+    update_url: "https://clients2.google.com/service/update2/crx"
+    incognito: true
+    installation_mode: "force_installed"
diff --git a/roles/desk-chromium/templates/configuration.yml.j2 b/roles/desk-chromium/templates/configuration.yml.j2
deleted file mode 100644
index 06df2d64..00000000
--- a/roles/desk-chromium/templates/configuration.yml.j2
+++ /dev/null
@@ -1,23 +0,0 @@
-# Concerning configuration options checkout:
-# https://chromeenterprise.google/policies/#ExtensionSettings
-chromium:
-  password_manager_enabled: false
-  default_installation_mode: allowed
-  plugins:
-    # UBlock Origin
-    - id: "cjpalhdlnbpafiamejdnhcphjbkeiagm"
-      update_url: "https://clients2.google.com/service/update2/crx"
-      incognito: true
-      installation_mode: "force_installed"
-
-    # KeepassXC
-    - id: "ddkjiahejlhfcafbddmgiahcphecmpfh"
-      update_url: "https://clients2.google.com/service/update2/crx"
-      incognito: false
-      installation_mode: "force_installed"
-
-    # Dark Mode Extension
-    - id: "dmghijelimhndkbmpgbldicpogfkceaj"
-      update_url: "https://clients2.google.com/service/update2/crx"
-      incognito: true
-      installation_mode: "force_installed"
diff --git a/roles/desk-chromium/templates/extensions_policy.json.j2 b/roles/desk-chromium/templates/extensions_policy.json.j2
index 5d24a615..9ab40ba5 100644
--- a/roles/desk-chromium/templates/extensions_policy.json.j2
+++ b/roles/desk-chromium/templates/extensions_policy.json.j2
@@ -1,6 +1,6 @@
 {
   "ExtensionInstallForcelist": [
-    {% for plugin in applications | get_app_conf(application_id, 'chromium.plugins', True) -%}
+    {% for plugin in applications | get_app_conf(application_id, 'plugins', True) -%}
     "{{ plugin.id }};{{ plugin.update_url }}"{% if not loop.last %},{% endif %}
     {% endfor %}
   ],
@@ -8,7 +8,7 @@
     "*": {
       "installation_mode": "{{ applications | get_app_conf(application_id, 'default_installation_mode', True) }}"
     }
-    {% for plugin in applications | get_app_conf(application_id, 'chromium.plugins', True) -%},
+    {% for plugin in applications | get_app_conf(application_id, 'plugins', True) -%},
     "{{ plugin.id }}": {
       "installation_mode": "{{ plugin.installation_mode }}",
       "update_url": "{{ plugin.update_url }}",