From e6fbb4b3f4edd20468f0312a4ec0adbcbef51676 Mon Sep 17 00:00:00 2001 From: Kevin Veen-Birkenbach Date: Thu, 24 Sep 2026 22:59:19 +0200 Subject: [PATCH] chore: drop two leftovers of the Wazuh role's first commit That commit added test_bcrypt_hash.py with an Exception comment and left a trailing blank line in group_vars/all/11_oidc.yml. Both go. What the comment said still holds: the test hashes with the raw bcrypt package because Ansible's password_hash('bcrypt') routes through passlib, whose bcrypt self-test can misreport a password well under 72 bytes as too long when passlib and the installed bcrypt disagree on the version. Co-Authored-By: Claude Opus 5.5 (1M context) --- group_vars/all/11_oidc.yml | 1 - tests/unit/python/plugins/filter/test_bcrypt_hash.py | 5 ----- 2 files changed, 6 deletions(-) diff --git a/group_vars/all/11_oidc.yml b/group_vars/all/11_oidc.yml index d3ef2a33e7..a6274d461b 100644 --- a/group_vars/all/11_oidc.yml +++ b/group_vars/all/11_oidc.yml @@ -54,4 +54,3 @@ defaults_oidc: CLI_CLIENT_ID: "admin-cli" OIDC: "{{ defaults_oidc | combine(OIDC_OVERRIDE | default({}, true), recursive=True) }}" - diff --git a/tests/unit/python/plugins/filter/test_bcrypt_hash.py b/tests/unit/python/plugins/filter/test_bcrypt_hash.py index 3db56665cf..8732d95e14 100644 --- a/tests/unit/python/plugins/filter/test_bcrypt_hash.py +++ b/tests/unit/python/plugins/filter/test_bcrypt_hash.py @@ -29,11 +29,6 @@ class TestBcryptHash(unittest.TestCase): self.assertTrue(hashed.startswith(("$2b$", "$2a$"))) def test_64_character_password_hashes_successfully(self): - # Exception: Ansible's password_hash('bcrypt') filter routes through - # passlib, whose bcrypt self-test can misreport a well-under-72-byte - # password as "too long" when passlib and the installed bcrypt - # package's version detection drift apart. The raw bcrypt package - # used here has no such self-test. password = "A" * 64 hashed = self.f(password) self.assertTrue(