From c7ff39169a6a37638e9ff834e44aaa5cf21127a1 Mon Sep 17 00:00:00 2001
From: Kevin Veen-Birkenbach <kevin@veen.world>
Date: Wed, 21 May 2025 14:20:34 +0200
Subject: [PATCH] Optimized moodle role

---
 roles/docker-moodle/README.md                 | 2 +-
 roles/docker-moodle/TODO.md                   | 3 +++
 roles/docker-moodle/templates/env.j2          | 9 ++++++++-
 roles/docker-moodle/vars/configuration.yml    | 2 +-
 roles/docker-wordpress/vars/configuration.yml | 2 +-
 5 files changed, 14 insertions(+), 4 deletions(-)
 create mode 100644 roles/docker-moodle/TODO.md

diff --git a/roles/docker-moodle/README.md b/roles/docker-moodle/README.md
index 7bb31e22..f982fb3b 100644
--- a/roles/docker-moodle/README.md
+++ b/roles/docker-moodle/README.md
@@ -2,7 +2,7 @@
 
 ## Description
 
-Ignite the learning experience with Moodle, a powerful and versatile platform for online education that energizes classrooms and fosters interactive learning. Moodle delivers a comprehensive set of tools for creating, managing, and sharing educational content, supporting collaboration among educators and learners alike.
+Ignite the learning experience with [Moodle](https://moodle.org/), a powerful and versatile platform for online education that energizes classrooms and fosters interactive learning. Moodle delivers a comprehensive set of tools for creating, managing, and sharing educational content, supporting collaboration among educators and learners alike.
 
 ## Overview
 
diff --git a/roles/docker-moodle/TODO.md b/roles/docker-moodle/TODO.md
new file mode 100644
index 00000000..1b84eb53
--- /dev/null
+++ b/roles/docker-moodle/TODO.md
@@ -0,0 +1,3 @@
+# Todo
+- Check if sendmail needs to be installed. See [Issue](https://github.com/bitnami/containers/issues/63311).
+- Solve [issue](https://github.com/bitnami/containers/issues/72747)
\ No newline at end of file
diff --git a/roles/docker-moodle/templates/env.j2 b/roles/docker-moodle/templates/env.j2
index b329481d..957d7632 100644
--- a/roles/docker-moodle/templates/env.j2
+++ b/roles/docker-moodle/templates/env.j2
@@ -10,4 +10,11 @@ MOODLE_REVERSE_PROXY=yes
 MOODLE_USERNAME={{applications[application_id].users.administrator.username}}
 MOODLE_PASSWORD={{applications[application_id].credentials.user_password}}
 MOODLE_EMAIL={{applications[application_id].users.administrator.email}}
-BITNAMI_DEBUG={% if enable_debug | bool %}true{% else %}false{% endif %}
\ No newline at end of file
+BITNAMI_DEBUG={% if enable_debug | bool %}true{% else %}false{% endif %}
+
+
+MOODLE_HOST={{ system_email.host }}
+MOODLE_SMTP_PORT_NUMBER={{ system_email.port }}
+MOODLE_SMTP_USER={{ users['no-reply'].email }}
+MOODLE_SMTP_PASSWORD={{ users['no-reply'].mailu_token }}
+MOODLE_SMTP_PROTOCOL={{ 'ssl' if system_email.tls else ('tls' if system_email.start_tls else '') }}
diff --git a/roles/docker-moodle/vars/configuration.yml b/roles/docker-moodle/vars/configuration.yml
index 8e5c4b37..43f675af 100644
--- a/roles/docker-moodle/vars/configuration.yml
+++ b/roles/docker-moodle/vars/configuration.yml
@@ -1,4 +1,4 @@
-site_titel:           "Global Learning Academy on {{primary_domain}}"
+site_titel:           "Academy on {{primary_domain}}"
 users:
   administrator:
     username:         "{{users.administrator.username}}"
diff --git a/roles/docker-wordpress/vars/configuration.yml b/roles/docker-wordpress/vars/configuration.yml
index 9632be1b..0fe513d9 100644
--- a/roles/docker-wordpress/vars/configuration.yml
+++ b/roles/docker-wordpress/vars/configuration.yml
@@ -13,7 +13,7 @@ plugins:
 features:
   matomo:             true
   css:                false
-  portfolio_iframe: false
+  portfolio_iframe:   false
   oidc:               true
   central_database:   true
 csp: