From c38d517ad37528d28372e4a801dbf9a59ce6dcfe Mon Sep 17 00:00:00 2001
From: Kevin Veen-Birkenbach <kevin@veen.world>
Date: Thu, 16 Nov 2023 15:42:09 +0100
Subject: [PATCH] Optimized ressources

---
 roles/update-docker/files/update-docker.py | 29 +++++++++++-----------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/roles/update-docker/files/update-docker.py b/roles/update-docker/files/update-docker.py
index 81122e95..28290b45 100644
--- a/roles/update-docker/files/update-docker.py
+++ b/roles/update-docker/files/update-docker.py
@@ -4,22 +4,23 @@ import sys
 import time
 
 def run_command(command):
-    process = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
-    output = []
+    process = None
+    try:
+        process = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+        output = []
 
-    # Iterate over the output lines
-    for line in iter(process.stdout.readline, b''):
-        decoded_line = line.decode()
-        output.append(decoded_line)
-        sys.stdout.write(decoded_line)
-
-    process.stdout.close()
-    return_code = process.wait()
-    if return_code:
-        # Join the output list to create a single string
-        full_output = ''.join(output)
-        raise subprocess.CalledProcessError(return_code, command, output=full_output.encode())
+        for line in iter(process.stdout.readline, b''):
+            decoded_line = line.decode()
+            output.append(decoded_line)
+            sys.stdout.write(decoded_line)
 
+        return_code = process.wait()
+        if return_code:
+            full_output = ''.join(output)
+            raise subprocess.CalledProcessError(return_code, command, output=full_output.encode())
+    finally:
+        if process and process.stdout:
+            process.stdout.close()
 
 def git_pull(directory):
     os.chdir(directory)